✨ Add bucket_regional_domain_name to aws_s3_bucket Data Source

[charlyx]

Hi again 👋

Thanks again for your work! 👏

This PR allows you to get bucket_regional_domain_name using a bucket data source.
I have updated the documentation accordingly.

Fix #7764

[bflad]

LGTM, thanks @charlyx 🚀 Please note: adding this quick acceptance testing piece on merge to ensure its covered:

resource.TestCheckResourceAttr("data.aws_s3_bucket.bucket", "bucket_regional_domain_name", testAccBucketRegionalDomainName(rInt, region)),

Output from acceptance testing:

--- PASS: TestAccDataSourceS3Bucket_basic (29.54s)
--- PASS: TestAccDataSourceS3Bucket_website (33.76s)

[bflad]

This has been released in version 2.1.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[matthewduren]

This breaks bucket auto-naming - we are passing in bucket = "${var.bucket_name}" to an aws_s3_bucket resource, the bucket_name variable defaults to "", which formerly caused buckets to be named by terraform (ex terraform-20190983249872394800000001). After this update, bucket names are throwing a length error:

Error: module.my_bucket.aws_s3_bucket.main: expected length of bucket to be in the range (3 - 63), got 

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!