Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_iot_topic_rule: Prevent panic with missing SQS UseBase64 attribute in API response #7337

Merged
merged 1 commit into from
Jan 25, 2019
Merged

resource/aws_iot_topic_rule: Prevent panic with missing SQS UseBase64 attribute in API response #7337

merged 1 commit into from
Jan 25, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 25, 2019

Fixes #7334

Terraform requires the attribute in the configuration block, so it is safe to parse nil to false.

Output from acceptance testing:

--- PASS: TestAccAWSIoTTopicRule_lambda (8.86s)
--- PASS: TestAccAWSIoTTopicRule_basic (9.29s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchalarm (9.29s)
--- PASS: TestAccAWSIoTTopicRule_s3 (9.31s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchmetric (9.35s)
--- PASS: TestAccAWSIoTTopicRule_sns (9.35s)
--- PASS: TestAccAWSIoTTopicRule_firehose (9.39s)
--- PASS: TestAccAWSIoTTopicRule_republish (9.41s)
--- PASS: TestAccAWSIoTTopicRule_sqs (9.43s)
--- PASS: TestAccAWSIoTTopicRule_kinesis (9.43s)
--- PASS: TestAccAWSIoTTopicRule_importbasic (9.96s)
--- PASS: TestAccAWSIoTTopicRule_elasticsearch (13.07s)
--- PASS: TestAccAWSIoTTopicRule_firehose_separator (13.55s)

@bflad
resource/aws_iot_topic_rule: Prevent panic with missing SQS UseBase64…
a8f0af8 
… attribute in API response

Reference: #7334

Output from acceptance testing:

```
--- PASS: TestAccAWSIoTTopicRule_lambda (8.86s)
--- PASS: TestAccAWSIoTTopicRule_basic (9.29s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchalarm (9.29s)
--- PASS: TestAccAWSIoTTopicRule_s3 (9.31s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchmetric (9.35s)
--- PASS: TestAccAWSIoTTopicRule_sns (9.35s)
--- PASS: TestAccAWSIoTTopicRule_firehose (9.39s)
--- PASS: TestAccAWSIoTTopicRule_republish (9.41s)
--- PASS: TestAccAWSIoTTopicRule_sqs (9.43s)
--- PASS: TestAccAWSIoTTopicRule_kinesis (9.43s)
--- PASS: TestAccAWSIoTTopicRule_importbasic (9.96s)
--- PASS: TestAccAWSIoTTopicRule_elasticsearch (13.07s)
--- PASS: TestAccAWSIoTTopicRule_firehose_separator (13.55s)
```
@bflad bflad requested a review from a team January 25, 2019 19:55
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jan 25, 2019
@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/iot Issues and PRs that pertain to the iot service. labels Jan 25, 2019
@bflad bflad added this to the v1.57.0 milestone Jan 25, 2019
@bflad bflad mentioned this pull request Jan 25, 2019
Closed
nywilken
nywilken approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 41b5117 into master Jan 25, 2019
@bflad bflad deleted the b-aws_iot_topic_rule-sqs-usebase64-panic branch January 25, 2019 20:35
bflad added a commit that referenced this pull request Jan 25, 2019
@bflad
Update CHANGELOG for #7337
645b801
@bflad
Copy link
Contributor Author

bflad commented Jan 26, 2019

This has been released in version 1.57.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/iot Issues and PRs that pertain to the iot service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.57.0
Development

Successfully merging this pull request may close these issues.

aws_iot_topic_rule fails to parse SQS in response
2 participants
@bflad @nywilken