Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Datasource: aws_api_gateway_vpc_link #6763

Merged
merged 5 commits into from
Dec 7, 2018
Merged

New Datasource: aws_api_gateway_vpc_link #6763

merged 5 commits into from
Dec 7, 2018

Conversation

ftrossbach
Copy link
Contributor

Changes proposed in this pull request:

  • Add a new data source for API Gateway VPC Links

Output from acceptance testing:

╰─$ make testacc TESTARGS='-run=TestAccDataSourceAwsApiGatewayVpcLink'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccDataSourceAwsApiGatewayVpcLink -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccDataSourceAwsApiGatewayVpcLink
=== PAUSE TestAccDataSourceAwsApiGatewayVpcLink
=== CONT  TestAccDataSourceAwsApiGatewayVpcLink
--- PASS: TestAccDataSourceAwsApiGatewayVpcLink (716.32s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       716.355s

...

@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 7, 2018
@bflad bflad added the new-data-source Introduces a new data source. label Dec 7, 2018
@bflad
Copy link
Contributor

bflad commented Dec 7, 2018

Sorry the TravisCI failure is my fault:

aws/resource_aws_cloudwatch_log_subscription_filter_test.go:1::warning: file is not gofmted with -s (gofmt)
make: *** [lint] Error 1

Its fixed on master now.

bflad
bflad reviewed Dec 7, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good, @ftrossbach, just a few minor testing things then this should be good to go. Thanks!

aws/data_source_aws_api_gateway_vpc_link_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_api_gateway_vpc_link_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_api_gateway_vpc_link_test.go Outdated Show resolved Hide resolved
@ftrossbach
Copy link
Contributor Author

I added your suggestions. Thanks for reviewing so quickly!

@bflad bflad added this to the v1.52.0 milestone Dec 7, 2018
bflad
bflad approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ftrossbach! 🚀

--- PASS: TestAccDataSourceAwsApiGatewayVpcLink (661.70s)

@bflad bflad merged commit d2de666 into hashicorp:master Dec 7, 2018
bflad added a commit that referenced this pull request Dec 7, 2018
@bflad
Update CHANGELOG for #6763
13530f2
@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ftrossbach @bflad