-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Availability Zone ID in data sources #6686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One cleanup item, then I think this is good to go, thanks @ewbankkit!
Changes made after code review. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAvailabilityZones_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAvailabilityZones_ -timeout 120m
=== RUN TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== CONT TestAccAWSAvailabilityZones_basic
=== CONT TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_stateFilter (14.62s)
--- PASS: TestAccAWSAvailabilityZones_basic (14.68s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 15.610s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @ewbankkit! 🚀
--- PASS: TestAccAWSAvailabilityZones_basic (4.00s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (4.13s)
--- PASS: TestAccDataSourceAwsAvailabilityZone (4.17s)
This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #6546.
zone_id
onaws_availability_zone
data sourcezone_ids
onaws_availability_zones
data sourceAcceptance tests: