Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Availability Zone ID in data sources #6686

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 2, 2018

Fixes #6546.

  • New attribute zone_id on aws_availability_zone data source
  • New attribute zone_ids on aws_availability_zones data source

Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsAvailabilityZone'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsAvailabilityZone -timeout 120m
=== RUN   TestAccDataSourceAwsAvailabilityZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone
=== CONT  TestAccDataSourceAwsAvailabilityZone
--- PASS: TestAccDataSourceAwsAvailabilityZone (14.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.605s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAvailabilityZones_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAvailabilityZones_ -timeout 120m
=== RUN   TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN   TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== CONT  TestAccAWSAvailabilityZones_basic
=== CONT  TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_basic (12.82s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (13.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	13.179s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 2, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One cleanup item, then I think this is good to go, thanks @ewbankkit!

aws/data_source_aws_availability_zones.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 3, 2018
@ewbankkit
Copy link
Contributor Author

Changes made after code review.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAvailabilityZones_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAvailabilityZones_ -timeout 120m
=== RUN   TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN   TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== CONT  TestAccAWSAvailabilityZones_basic
=== CONT  TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_stateFilter (14.62s)
--- PASS: TestAccAWSAvailabilityZones_basic (14.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.610s

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 3, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 3, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 3, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ewbankkit! 🚀

--- PASS: TestAccAWSAvailabilityZones_basic (4.00s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (4.13s)
--- PASS: TestAccDataSourceAwsAvailabilityZone (4.17s)

@bflad bflad merged commit ec3efcd into hashicorp:master Dec 3, 2018
bflad added a commit that referenced this pull request Dec 3, 2018
@ewbankkit ewbankkit deleted the issue-6546 branch December 3, 2018 18:40
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the new ZoneId field on Availability Zones
2 participants