Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/codedeploy_config: add support for lambda and traffic_routing #6644

Merged
merged 1 commit into from
Dec 2, 2018
Merged

r/codedeploy_config: add support for lambda and traffic_routing #6644

merged 1 commit into from
Dec 2, 2018

Conversation

acburdine
Copy link
Contributor

fixes #5393, refs #4839

Changes proposed in this pull request:

  • adds traffic_routing_config sub-resource to
    codedeploy_deployment_config resource
  • add computed_platform optional element
  • make minimum_healthy_hosts optional as per aws api spec

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeDeployDeploymentConfig'
--- PASS: TestAccAWSCodeDeployDeploymentConfig_basic (12.91s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_trafficLinear (18.88s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_hostCount (19.60s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_trafficCanary (19.96s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_fleetPercent (20.19s)
PASS

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/codedeploy tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 29, 2018
bflad
bflad reviewed Nov 30, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @acburdine 👍 I think this is off to a good start. Hopefully a few little things then this is good to go.

aws/resource_aws_codedeploy_deployment_config.go Outdated Show resolved Hide resolved
aws/resource_aws_codedeploy_deployment_config.go Outdated Show resolved Hide resolved
aws/resource_aws_codedeploy_deployment_config.go Outdated Show resolved Hide resolved
aws/resource_aws_codedeploy_deployment_config.go Outdated Show resolved Hide resolved
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 30, 2018
@acburdine
r/codedeploy_config: add support for lambda and traffic_routing
d6b4d8f 
fixes hashicorp#5393, refs hashicorp#4839
- adds traffic_routing_config sub-resource to
codedeploy_deployment_config resource
- add computed_platform optional element
- make minimum_healthy_hosts optional as per aws api spec
@acburdine acburdine force-pushed the r/codedeploy_config_lambda branch from 6adfca8 to d6b4d8f Compare November 30, 2018 23:40
@acburdine
Copy link
Contributor Author

@bflad made the changes you suggested

make testacc TESTARGS='-run=TestAccAWSCodeDeployDeploymentConfig'
--- PASS: TestAccAWSCodeDeployDeploymentConfig_basic (10.86s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_trafficCanary (15.62s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_fleetPercent (16.48s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_trafficLinear (16.64s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_hostCount (17.39s)
PASS

bflad
bflad approved these changes Dec 2, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @acburdine, thanks so much! 🚀

--- PASS: TestAccAWSCodeDeployDeploymentConfig_basic (4.71s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_trafficCanary (6.37s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_fleetPercent (6.46s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_trafficLinear (7.92s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_hostCount (8.13s)

@bflad bflad merged commit ae44c07 into hashicorp:master Dec 2, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 2, 2018
@acburdine acburdine deleted the r/codedeploy_config_lambda branch December 2, 2018 03:27
bflad added a commit that referenced this pull request Dec 2, 2018
@bflad
Update CHANGELOG for #6644
b398497
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.51.0
Development

Successfully merging this pull request may close these issues.

More CodeDeploy for Lambda
2 participants
@acburdine @bflad