Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set apply_method to state in aws_rds_cluster_parameter_group #6295

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Set apply_method to state in aws_rds_cluster_parameter_group #6295

merged 2 commits into from
Oct 30, 2018

Conversation

jc-asdf
Copy link
Contributor

@jc-asdf jc-asdf commented Oct 29, 2018

Following the pattern of hashicorp/terraform#8603
which addressed a similar issue with the db parameter groups.

Fixes #4832

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDBClusterParameterGroup'


==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDBClusterParameterGroup -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSDBClusterParameterGroup_importBasic
=== PAUSE TestAccAWSDBClusterParameterGroup_importBasic
=== RUN   TestAccAWSDBClusterParameterGroup_basic
=== PAUSE TestAccAWSDBClusterParameterGroup_basic
=== RUN   TestAccAWSDBClusterParameterGroup_withApplyMethod
=== PAUSE TestAccAWSDBClusterParameterGroup_withApplyMethod
=== RUN   TestAccAWSDBClusterParameterGroup_namePrefix
=== PAUSE TestAccAWSDBClusterParameterGroup_namePrefix
=== RUN   TestAccAWSDBClusterParameterGroup_generatedName
=== PAUSE TestAccAWSDBClusterParameterGroup_generatedName
=== RUN   TestAccAWSDBClusterParameterGroup_disappears
=== PAUSE TestAccAWSDBClusterParameterGroup_disappears
=== RUN   TestAccAWSDBClusterParameterGroupOnly
=== PAUSE TestAccAWSDBClusterParameterGroupOnly
=== CONT  TestAccAWSDBClusterParameterGroup_importBasic
=== CONT  TestAccAWSDBClusterParameterGroup_generatedName
=== CONT  TestAccAWSDBClusterParameterGroupOnly
=== CONT  TestAccAWSDBClusterParameterGroup_withApplyMethod
=== CONT  TestAccAWSDBClusterParameterGroup_namePrefix
=== CONT  TestAccAWSDBClusterParameterGroup_basic
=== CONT  TestAccAWSDBClusterParameterGroup_disappears
--- PASS: TestAccAWSDBClusterParameterGroup_disappears (8.19s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (10.62s)
--- PASS: TestAccAWSDBClusterParameterGroupOnly (10.81s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (10.87s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (11.13s)
--- PASS: TestAccAWSDBClusterParameterGroup_importBasic (12.26s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (19.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.097s

Following the pattern of hashicorp/terraform#8603
which addressed a similar issue with the db parameter groups.
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 29, 2018
@jc-asdf
Copy link
Contributor Author

jc-asdf commented Oct 29, 2018

re-ran formatting, tests, and linting with same version of Go as Travis (1.11.1); cleaned up a whitespace difference.

@bflad bflad added the bug Addresses a defect in current functionality. label Oct 30, 2018
@bflad bflad added this to the v1.42.0 milestone Oct 30, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jc-asdf! 🚀 At first I was confused because this PR didn't include anything to eventually update the information passed to d.Set(), but it looks like this resource utilizes the same flatten function as the other resource. 👍

--- PASS: TestAccAWSDBClusterParameterGroup_disappears (3.25s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (4.07s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (4.17s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (4.19s)
--- PASS: TestAccAWSDBClusterParameterGroup_importBasic (4.32s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (6.58s)

@bflad bflad merged commit c434f5b into hashicorp:master Oct 30, 2018
bflad added a commit that referenced this pull request Oct 30, 2018
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_rds_cluster_parameter_group values not saving and are re-set on every apply
2 participants