Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #6096 Typo in data_source_aws_network_interface #6284

Merged
merged 1 commit into from
Oct 30, 2018
Merged

issue #6096 Typo in data_source_aws_network_interface #6284

merged 1 commit into from
Oct 30, 2018

Conversation

saravanan30erd
Copy link
Contributor

Fixes #6096

Changes proposed in this pull request:

  • Change 1
    Fixed the typo in private_ip attr and also updated the acceptance test.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsNetworkInterface_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsNetworkInterface_basic -timeout 120m
=== RUN   TestAccDataSourceAwsNetworkInterface_basic
=== PAUSE TestAccDataSourceAwsNetworkInterface_basic
=== CONT  TestAccDataSourceAwsNetworkInterface_basic
--- PASS: TestAccDataSourceAwsNetworkInterface_basic (93.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	93.278s
...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 26, 2018
@bflad bflad added the bug Addresses a defect in current functionality. label Oct 30, 2018
@bflad bflad added this to the v1.42.0 milestone Oct 30, 2018
bflad
bflad approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @saravanan30erd! 🚀

--- PASS: TestAccDataSourceAwsNetworkInterface_filters (9.33s)
--- PASS: TestAccDataSourceAwsNetworkInterface_basic (9.36s)

@bflad bflad merged commit b2bedcb into hashicorp:master Oct 30, 2018
bflad added a commit that referenced this pull request Oct 30, 2018
@bflad
Update CHANGELOG for #6284
acb7785
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.

Typo in data_source_aws_network_interface
2 participants
@saravanan30erd @bflad