Issue #6054 Add name_prefix attribute to aws_secretsmanager_secret

[saravanan30erd]

Fixes #6054

Changes proposed in this pull request:

• Change 1
  added name_prefix attribute to aws_secretsmanager_secret
• Change 2
  added the validation func for attr name and name_prefix.
  Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsSecretsManagerSecret_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsSecretsManagerSecret_ -timeout 120m
=== RUN   TestAccAwsSecretsManagerSecret_Basic
=== PAUSE TestAccAwsSecretsManagerSecret_Basic
=== RUN   TestAccAwsSecretsManagerSecret_withNamePrefix
=== PAUSE TestAccAwsSecretsManagerSecret_withNamePrefix
=== RUN   TestAccAwsSecretsManagerSecret_Description
=== PAUSE TestAccAwsSecretsManagerSecret_Description
=== RUN   TestAccAwsSecretsManagerSecret_KmsKeyID
=== PAUSE TestAccAwsSecretsManagerSecret_KmsKeyID
=== RUN   TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate
=== PAUSE TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate
=== RUN   TestAccAwsSecretsManagerSecret_RotationLambdaARN
=== PAUSE TestAccAwsSecretsManagerSecret_RotationLambdaARN
=== RUN   TestAccAwsSecretsManagerSecret_RotationRules
=== PAUSE TestAccAwsSecretsManagerSecret_RotationRules
=== RUN   TestAccAwsSecretsManagerSecret_Tags
=== PAUSE TestAccAwsSecretsManagerSecret_Tags
=== RUN   TestAccAwsSecretsManagerSecret_policy
=== PAUSE TestAccAwsSecretsManagerSecret_policy
=== CONT  TestAccAwsSecretsManagerSecret_Basic
=== CONT  TestAccAwsSecretsManagerSecret_RotationLambdaARN
=== CONT  TestAccAwsSecretsManagerSecret_policy
=== CONT  TestAccAwsSecretsManagerSecret_KmsKeyID
=== CONT  TestAccAwsSecretsManagerSecret_Tags
=== CONT  TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate
=== CONT  TestAccAwsSecretsManagerSecret_Description
=== CONT  TestAccAwsSecretsManagerSecret_withNamePrefix
=== CONT  TestAccAwsSecretsManagerSecret_RotationRules
--- PASS: TestAccAwsSecretsManagerSecret_policy (33.37s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (37.74s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (37.85s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (61.29s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (68.84s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (107.49s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (107.53s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (112.61s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (120.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	120.271s
...

[bflad]

This is looking pretty good -- I think it just needs to be rebased due to merging the other validation function PR and adding ValidateFunc to the attributes 😄

[saravanan30erd]

@bflad changes done 👍

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsSecretsManagerSecret_withNamePrefix'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsSecretsManagerSecret_withNamePrefix -timeout 120m
=== RUN TestAccAwsSecretsManagerSecret_withNamePrefix
=== PAUSE TestAccAwsSecretsManagerSecret_withNamePrefix
=== CONT TestAccAwsSecretsManagerSecret_withNamePrefix
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (36.27s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 36.313s

[bflad]

LGTM, thanks @saravanan30erd! 🚀

9 tests passed (all tests)
--- PASS: TestAccAwsSecretsManagerSecret_policy (4.54s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (4.98s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (5.00s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (7.44s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (13.03s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (22.96s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (26.98s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (27.00s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (27.68s)

[bflad]

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!