Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resouce/aws_waf_rule: add import ability #6247

Merged
merged 1 commit into from
Oct 25, 2018
Merged

resouce/aws_waf_rule: add import ability #6247

merged 1 commit into from
Oct 25, 2018

Conversation

acburdine
Copy link
Contributor

Changes proposed in this pull request:

  • Add import ability to waf rule (following similar approach as 742357c)

Output from acceptance testing:

=== RUN   TestAccAWSWafRule_basic
=== PAUSE TestAccAWSWafRule_basic
=== CONT  TestAccAWSWafRule_basic
--- PASS: TestAccAWSWafRule_basic (16.65s)
PASS

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 23, 2018
bflad
bflad reviewed Oct 25, 2018
View reviewed changes
aws/resource_aws_waf_rule_test.go
@@ -34,6 +34,11 @@ func TestAccAWSWafRule_basic(t *testing.T) {
"aws_waf_rule.wafrule", "metric_name", wafRuleName),
),
},
{
Copy link
Contributor

@bflad bflad Oct 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this TestStep to all the resource acceptance tests? That helps us verify that all resource configurations are imported correctly. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually since most of the tests aren't verifying additional configurations other than TestAccAWSWafRule_geoMatchSetPredicate, we can probably just get this in as-is.

bflad
bflad approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @acburdine! 🚀

6 tests passed (all tests)
--- PASS: TestAccAWSWafRule_noPredicates (14.47s)
--- PASS: TestAccAWSWafRule_geoMatchSetPredicate (37.41s)
--- PASS: TestAccAWSWafRule_changePredicates (44.45s)
--- PASS: TestAccAWSWafRule_disappears (63.88s)
--- PASS: TestAccAWSWafRule_changeNameForceNew (78.80s)
--- PASS: TestAccAWSWafRule_basic (101.94s)

@bflad bflad added this to the v1.42.0 milestone Oct 25, 2018
@bflad bflad merged commit 9d97f4e into hashicorp:master Oct 25, 2018
bflad added a commit that referenced this pull request Oct 25, 2018
@bflad
Update CHANGELOG for #6247
398cc11
@acburdine acburdine deleted the feat/waf_rule_import branch October 26, 2018 10:37
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@acburdine @bflad