Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the custom domain name feature in aws_cognito_user_pool_domain resource #6185

Merged
merged 4 commits into from
Oct 31, 2018

Conversation

adelamarre
Copy link
Contributor

Fixes #5026

Changes proposed in this pull request:

  • Add the certificate_arn parameter to let use a custom domain

Output from acceptance testing:

You need to set environment variable for this test :

  • AWS_COGNITO_USER_POOL_DOMAIN_ROOT_DOMAIN
    This environment variable must be set to the fqdn of an ISSUED ACM certificate in us-east-1 to enable this test. The fqdn must have a A record in the zone.
  • AWS_COGNITO_USER_POOL_DOMAIN_CERTIFICATE_ARN
    This environment variable must be set to the ARN of an ISSUED ACM certificate in us-east-1 to enable this test.
$ make testacc TESTARGS='-run=TestAccAWSCognitoUserPoolDomain_custom'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSCognitoUserPoolDomain_custom -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCognitoUserPoolDomain_custom
--- PASS: TestAccAWSCognitoUserPoolDomain_custom (2013.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2013.299s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/cognito tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 17, 2018
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Oct 17, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adelamarre 👋 Thanks for submitting this! Off to a great start -- I think just these two little things then it should be good to go. Please let us know if you have any questions or do not have time to implement the feedback. 👍

aws/resource_aws_cognito_user_pool_domain.go Show resolved Hide resolved
aws/resource_aws_cognito_user_pool_domain.go Outdated Show resolved Hide resolved
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Oct 28, 2018
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 31, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @adelamarre! I was able to verify this using the environment variables with a public ACM certificate and domain. 🚀

--- PASS: TestAccAWSCognitoUserPoolDomain_basic (9.03s)
--- PASS: TestAccAWSCognitoUserPoolDomain_custom (1563.45s)

@bflad bflad added this to the v1.42.0 milestone Oct 31, 2018
@bflad bflad merged commit 330babd into hashicorp:master Oct 31, 2018
bflad added a commit that referenced this pull request Oct 31, 2018
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - support custom domain in aws_cognito_user_pool_domain
2 participants