Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all DX connection speeds #6057

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Conversation

ewbankkit
Copy link
Contributor

Fixes #6043.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDxConnection_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSDxConnection_basic -timeout 120m
=== RUN   TestAccAWSDxConnection_basic
--- PASS: TestAccAWSDxConnection_basic (41.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.373s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDxLag_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSDxLag_basic -timeout 120m
=== RUN   TestAccAWSDxLag_basic
--- PASS: TestAccAWSDxLag_basic (118.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	119.199s

@ghost ghost added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Oct 3, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service. labels Oct 3, 2018
@bflad bflad added this to the v1.39.0 milestone Oct 3, 2018
@bflad bflad merged commit 7b6d740 into hashicorp:master Oct 3, 2018
@bflad
Copy link
Contributor

bflad commented Oct 3, 2018

Whoops meant to hit "approve" before merge 😄 LGTM!

bflad added a commit that referenced this pull request Oct 3, 2018
@ewbankkit ewbankkit deleted the issue-6043 branch October 3, 2018 14:46
@ghost
Copy link

ghost commented Oct 3, 2018

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "aws" {
	version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_dx_connection accepted lower bandwiths
2 participants