Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudwatch-event-ecs-target #5982

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

wardviaene
Copy link
Contributor

@wardviaene wardviaene commented Sep 25, 2018

Fixes #5722

Changes proposed in this pull request:

  • Added new EcsParameters (including changes to test to include new parameters)
  • Added Documentation

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchEventTarget_ecs'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudWatchEventTarget_ecs -timeout 120m
=== RUN   TestAccAWSCloudWatchEventTarget_ecs
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (70.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	70.216s
...

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 25, 2018
@wardviaene wardviaene force-pushed the cloudwatch-event-ecs-target branch from 829f0b3 to b962e3c Compare September 26, 2018 11:47
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 26, 2018
@wardviaene wardviaene changed the title [WIP] cloudwatch-event-ecs-target cloudwatch-event-ecs-target Sep 26, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in, thanks @wardviaene! 🚀

--- PASS: TestAccAWSCloudWatchEventTarget_missingTargetId (4.37s)
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (4.53s)
--- PASS: TestAccAWSCloudWatchEventTarget_basic (7.16s)
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (7.90s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (8.55s)
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (22.24s)
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (73.32s)
--- PASS: TestAccAWSCloudWatchEventTarget_full (73.88s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (75.98s)

@bflad bflad added this to the v1.39.0 milestone Sep 27, 2018
@bflad bflad merged commit 57e34c0 into hashicorp:master Sep 27, 2018
bflad added a commit that referenced this pull request Sep 27, 2018
@ghost
Copy link

ghost commented Oct 3, 2018

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "aws" {
	version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional ECS parameters for CloudWatch events target
2 participants