New Resource: aws_ec2_fleet #5960

bflad · 2018-09-21T23:59:18Z

Changes proposed in this pull request:

New Resource: aws_ec2_fleet

Output from acceptance testing:

Tests passed: 25, ignored: 1
--- PASS: TestAccAWSEc2Fleet_basic (26.31s)
--- PASS: TestAccAWSEc2Fleet_disappears (26.95s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_Overrides_InstanceType (49.06s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_LaunchTemplateSpecification_LaunchTemplateId (55.89s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_LaunchTemplateSpecification_LaunchTemplateName (56.60s)
--- PASS: TestAccAWSEc2Fleet_ExcessCapacityTerminationPolicy (58.72s)
--- PASS: TestAccAWSEc2Fleet_Tags (59.63s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_AllocationStrategy (62.09s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_LaunchTemplateSpecification_Version (61.98s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_OnDemand (35.94s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType (62.78s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_Overrides_WeightedCapacity (62.83s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_InstancePoolsToUseCount (63.36s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_InstanceInterruptionBehavior (63.30s)
--- PASS: TestAccAWSEc2Fleet_ReplaceUnhealthyInstances (65.50s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_Overrides_Priority (66.12s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_Overrides_Priority_Multiple (66.07s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_Spot (40.08s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_Overrides_SubnetId (67.60s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_Overrides_WeightedCapacity_Multiple (67.61s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfigs_Overrides_AvailabilityZone (76.65s)
--- PASS: TestAccAWSEc2Fleet_OnDemandOptions_AllocationStrategy (79.66s)
--- PASS: TestAccAWSEc2Fleet_Type (25.54s)
--- PASS: TestAccAWSEc2Fleet_TerminateInstancesWithExpiration (47.88s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_TotalTargetCapacity (423.74s)

zytek · 2018-09-25T14:58:10Z

Does this supersede ec2_spot_fleet ? Seems so.

cread · 2018-09-25T15:23:18Z

They are two separate AWS services.

aws/resource_aws_ec2_fleet.go

paultyng · 2018-10-03T00:33:13Z

aws/resource_aws_ec2_fleet.go

+								},
+							},
+						},
+						"overrides": {


should be singular

Will update code, testing, and documentation. 👍

aws/resource_aws_ec2_fleet.go

paultyng · 2018-10-03T00:35:20Z

aws/resource_aws_ec2_fleet.go

+
+	input := &ec2.CreateFleetInput{
+		ExcessCapacityTerminationPolicy:  aws.String(d.Get("excess_capacity_termination_policy").(string)),
+		LaunchTemplateConfigs:            expandEc2FleetLaunchTemplateConfigRequests(d.Get("launch_template_configs").([]interface{})),


I feel like these casts are panic potential, but won't hold up a merge over it

Calling d.Get() against a schema.TypeList will always return a []interface{} with 0 or more elements 😄

aws/resource_aws_ec2_fleet.go

bflad · 2018-10-03T01:28:26Z

@paultyng feedback hopefully addressed! 😄

Output from acceptance testing:

--- PASS: TestAccAWSEc2Fleet_basic (35.71s)
--- PASS: TestAccAWSEc2Fleet_disappears (32.21s)
--- PASS: TestAccAWSEc2Fleet_ExcessCapacityTerminationPolicy (94.75s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateId (72.23s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateName (65.05s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_Version (66.15s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_AvailabilityZone (64.70s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_InstanceType (70.11s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority (62.72s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority_Multiple (62.67s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_SubnetId (84.59s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity (66.18s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity_Multiple (66.18s)
--- PASS: TestAccAWSEc2Fleet_OnDemandOptions_AllocationStrategy (65.99s)
--- PASS: TestAccAWSEc2Fleet_ReplaceUnhealthyInstances (67.76s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_AllocationStrategy (65.17s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_InstanceInterruptionBehavior (64.85s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_InstancePoolsToUseCount (62.53s)
--- PASS: TestAccAWSEc2Fleet_Tags (65.32s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType (64.69s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_OnDemand (32.68s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_Spot (34.97s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_TotalTargetCapacity (468.10s)
--- PASS: TestAccAWSEc2Fleet_TerminateInstancesWithExpiration (63.03s)
--- PASS: TestAccAWSEc2Fleet_Type (32.81s)

Output from acceptance testing: ``` --- PASS: TestAccAWSEc2Fleet_basic (35.71s) --- PASS: TestAccAWSEc2Fleet_disappears (32.21s) --- PASS: TestAccAWSEc2Fleet_ExcessCapacityTerminationPolicy (94.75s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateId (72.23s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateName (65.05s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_Version (66.15s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_AvailabilityZone (64.70s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_InstanceType (70.11s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority (62.72s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority_Multiple (62.67s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_SubnetId (84.59s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity (66.18s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity_Multiple (66.18s) --- PASS: TestAccAWSEc2Fleet_OnDemandOptions_AllocationStrategy (65.99s) --- PASS: TestAccAWSEc2Fleet_ReplaceUnhealthyInstances (67.76s) --- PASS: TestAccAWSEc2Fleet_SpotOptions_AllocationStrategy (65.17s) --- PASS: TestAccAWSEc2Fleet_SpotOptions_InstanceInterruptionBehavior (64.85s) --- PASS: TestAccAWSEc2Fleet_SpotOptions_InstancePoolsToUseCount (62.53s) --- PASS: TestAccAWSEc2Fleet_Tags (65.32s) --- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType (64.69s) --- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_OnDemand (32.68s) --- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_Spot (34.97s) --- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_TotalTargetCapacity (468.10s) --- PASS: TestAccAWSEc2Fleet_TerminateInstancesWithExpiration (63.03s) --- PASS: TestAccAWSEc2Fleet_Type (32.81s) ```

ghost · 2018-10-03T18:54:37Z

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "aws" {
	version = "~> 1.39.0"
}
# ... other configuration ...

ghost · 2020-04-03T17:17:48Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

bflad added new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 21, 2018

ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 21, 2018

bflad mentioned this pull request Sep 22, 2018

EC2 Fleet Resource #4581

Closed

bflad force-pushed the f-aws_ec2_fleet branch from 8c3f51c to 859f607 Compare September 24, 2018 14:07

ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 24, 2018

New Resource: aws_ec2_fleet

e5eed2f

bflad force-pushed the f-aws_ec2_fleet branch from 859f607 to e5eed2f Compare September 24, 2018 14:27

ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 24, 2018

bflad requested a review from a team September 24, 2018 14:58

bflad changed the title ~~[WIP] New Resource: aws_ec2_fleet~~ New Resource: aws_ec2_fleet Sep 24, 2018

paultyng suggested changes Oct 3, 2018

View reviewed changes

bflad force-pushed the f-aws_ec2_fleet branch from a9670f8 to 31a8f71 Compare October 3, 2018 01:31

paultyng approved these changes Oct 3, 2018

View reviewed changes

bflad added this to the v1.39.0 milestone Oct 3, 2018

bflad merged commit d93081b into master Oct 3, 2018

bflad deleted the f-aws_ec2_fleet branch October 3, 2018 17:30

bflad added a commit that referenced this pull request Oct 3, 2018

Update CHANGELOG for #5960

3b91fb8

ghost locked and limited conversation to collaborators Apr 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: aws_ec2_fleet #5960

New Resource: aws_ec2_fleet #5960

bflad commented Sep 21, 2018 •

edited

Loading

zytek commented Sep 25, 2018

cread commented Sep 25, 2018

paultyng Oct 3, 2018

bflad Oct 3, 2018

paultyng Oct 3, 2018

bflad Oct 3, 2018

bflad commented Oct 3, 2018

ghost commented Oct 3, 2018

ghost commented Apr 3, 2020

New Resource: aws_ec2_fleet #5960

New Resource: aws_ec2_fleet #5960

Conversation

bflad commented Sep 21, 2018 • edited Loading

zytek commented Sep 25, 2018

cread commented Sep 25, 2018

paultyng Oct 3, 2018

Choose a reason for hiding this comment

bflad Oct 3, 2018

Choose a reason for hiding this comment

paultyng Oct 3, 2018

Choose a reason for hiding this comment

bflad Oct 3, 2018

Choose a reason for hiding this comment

bflad commented Oct 3, 2018

ghost commented Oct 3, 2018

ghost commented Apr 3, 2020

bflad commented Sep 21, 2018 •

edited

Loading