Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_config_config_rule: Prevent panic when specifying empty scope #5852

Merged
merged 1 commit into from
Sep 14, 2018
Merged

resource/aws_config_config_rule: Prevent panic when specifying empty scope #5852

merged 1 commit into from
Sep 14, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 12, 2018

Previously:

=== RUN   TestAccAWSConfig/Config/scopeTagKeyEmpty
panic: interface conversion: interface {} is nil, not map[string]interface {}

goroutine 1709 [running]:
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsConfigConfigRulePut(0xc0002e8fc0, 0x3c46240, 0xc0000b2600, 0x24, 0x71ead40)
	/Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_config_config_rule.go:154 +0x7e6

Fixes #5848

Changes proposed in this pull request:

  • Perform nil check on first scope element to prevent panic

Output from acceptance testing:

    --- PASS: TestAccAWSConfig/Config (813.73s)
        --- PASS: TestAccAWSConfig/Config/scopeTagKeyEmpty (92.12s)
        --- PASS: TestAccAWSConfig/Config/scopeTagValue (102.35s)
        --- PASS: TestAccAWSConfig/Config/basic (89.41s)
        --- PASS: TestAccAWSConfig/Config/ownerAws (89.83s)
        --- PASS: TestAccAWSConfig/Config/customlambda (117.45s)
        --- PASS: TestAccAWSConfig/Config/importAws (92.53s)
        --- PASS: TestAccAWSConfig/Config/importLambda (128.34s)
        --- PASS: TestAccAWSConfig/Config/scopeTagKey (101.71s)

@bflad
resource/aws_config_config_rule: Prevent panic when specifying empty …
09dfed0 
…scope

Previously:

```
=== RUN   TestAccAWSConfig/Config/scopeTagKeyEmpty
panic: interface conversion: interface {} is nil, not map[string]interface {}

goroutine 1709 [running]:
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsConfigConfigRulePut(0xc0002e8fc0, 0x3c46240, 0xc0000b2600, 0x24, 0x71ead40)
	/Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_config_config_rule.go:154 +0x7e6
```

Now:

```
        --- PASS: TestAccAWSConfig/Config/scopeTagKeyEmpty (101.17s)
```
@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/configservice Issues and PRs that pertain to the configservice service. labels Sep 12, 2018
@bflad bflad requested a review from a team September 12, 2018 15:54
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Sep 12, 2018
This was referenced Sep 12, 2018
Closed
Merged
@bflad bflad requested review from a team and removed request for a team September 13, 2018 18:38
tombuildsstuff
tombuildsstuff approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.37.0 milestone Sep 14, 2018
@bflad bflad merged commit e152430 into master Sep 14, 2018
@bflad bflad deleted the b-aws_config_config_rule-scope-panic branch September 14, 2018 12:51
bflad added a commit that referenced this pull request Sep 14, 2018
@bflad
Update CHANGELOG for #5852
533faa9
@bflad
Copy link
Contributor Author

bflad commented Sep 19, 2018

This has been released in version 1.37.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/configservice Issues and PRs that pertain to the configservice service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.37.0
Development

Successfully merging this pull request may close these issues.

panic: interface conversion: interface {} is nil, not map[string]interface {} in aws_config_config_rule
2 participants
@bflad @tombuildsstuff