Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_eks_cluster, d/aws_eks_cluster: Add support for EKS Platform Version #5797

Merged
merged 1 commit into from
Sep 5, 2018
Merged

r/aws_eks_cluster, d/aws_eks_cluster: Add support for EKS Platform Version #5797

merged 1 commit into from
Sep 5, 2018

Conversation

ewbankkit
Copy link
Contributor

Fixes #5796.

Acceptance tests:

=== RUN   TestAccAWSEksClusterDataSource_basic
--- PASS: TestAccAWSEksClusterDataSource_basic (1171.79s)
=== RUN   TestAccAWSEksCluster_basic
--- PASS: TestAccAWSEksCluster_basic (1073.15s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. labels Sep 5, 2018
@bflad bflad added this to the v1.35.0 milestone Sep 5, 2018
bflad
bflad approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ewbankkit! 🚀

4 tests passed (all tests)
--- PASS: TestAccAWSEksClusterDataSource_basic (1099.02s)
--- PASS: TestAccAWSEksCluster_Version (1129.11s)
--- PASS: TestAccAWSEksCluster_basic (1209.34s)
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1049.28s)

@bflad bflad merged commit f0359b9 into hashicorp:master Sep 5, 2018
bflad added a commit that referenced this pull request Sep 5, 2018
@bflad
Update CHANGELOG for #5797
0cd38b7
@ewbankkit ewbankkit deleted the issue-5796 branch September 5, 2018 19:27
@bflad
Copy link
Contributor

bflad commented Sep 6, 2018

This has been released in version 1.35.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Milestone
v1.35.0
Development

Successfully merging this pull request may close these issues.

aws_eks_cluster: Add support for Platform Version attribute
2 participants
@ewbankkit @bflad