Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ssm_document: Fix Deletion of Privately Shared Documents #5668

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

brandonstevens
Copy link
Contributor

@brandonstevens brandonstevens commented Aug 23, 2018

Partially Fixes Reference: #5308

Changes proposed in this pull request:

  • Fix Deletion of Privately Shared Documents

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMDocument_permission'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSSSMDocument_permission -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSSMDocument_permission_public
--- PASS: TestAccAWSSSMDocument_permission_public (120.00s)
=== RUN   TestAccAWSSSMDocument_permission_private
--- PASS: TestAccAWSSSMDocument_permission_private (137.59s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       257.630s

@bflad bflad added bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service. labels Aug 27, 2018
@bflad bflad added this to the v1.34.0 milestone Aug 27, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @brandonstevens! 🚀

--- PASS: TestAccAWSSSMDocument_permission_public (19.60s)
--- PASS: TestAccAWSSSMDocument_permission_private (19.74s)
--- PASS: TestAccAWSSSMDocument_params (23.44s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (26.14s)
--- PASS: TestAccAWSSSMDocument_update (26.25s)
--- PASS: TestAccAWSSSMDocument_basic (28.88s)
--- PASS: TestAccAWSSSMDocument_automation (39.47s)
--- PASS: TestAccAWSSSMDocument_Tags (41.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.808s

@bflad bflad merged commit 461aab2 into hashicorp:master Aug 27, 2018
bflad added a commit that referenced this pull request Aug 27, 2018
@bflad
Copy link
Contributor

bflad commented Aug 30, 2018

This has been released in version 1.34.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@brandonstevens brandonstevens deleted the ssm-doc-fix-deletes branch September 27, 2018 23:35
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants