-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #5374 New Datasource: aws_db_event_categories #5514
Conversation
@bflad is there anything I can do to push this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one non-blocking maintainability note. Thanks, @saravanan30erd! 🚀
2 tests passed (all tests)
--- PASS: TestAccAWSDbEventCategories_basic (3.70s)
--- PASS: TestAccAWSDbEventCategories_sourceType (3.78s)
data "aws_db_event_categories" "example" {} | ||
` | ||
|
||
var completeEventCategoriesList = []string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future maintainability note: this testing will break if AWS ever introduces new event categories -- generally speaking it would be better to ensure these values are included at a minimum rather than equally
This has been released in version 1.38.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #5374
Output from acceptance testing: