Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5374 New Datasource: aws_db_event_categories #5514

Merged
merged 6 commits into from
Sep 26, 2018

Conversation

saravanan30erd
Copy link
Contributor

Fixes #5374

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDbEventCategories_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSDbEventCategories_ -timeout 120m
=== RUN   TestAccAWSDbEventCategories_basic
--- PASS: TestAccAWSDbEventCategories_basic (31.83s)
=== RUN   TestAccAWSDbEventCategories_sourceType
--- PASS: TestAccAWSDbEventCategories_sourceType (30.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	62.069s
...

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Aug 11, 2018
@radeksimko radeksimko added new-data-source Introduces a new data source. service/rds Issues and PRs that pertain to the rds service. labels Aug 13, 2018
@saravanan30erd
Copy link
Contributor Author

@bflad is there anything I can do to push this.

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one non-blocking maintainability note. Thanks, @saravanan30erd! 🚀

2 tests passed (all tests)
--- PASS: TestAccAWSDbEventCategories_basic (3.70s)
--- PASS: TestAccAWSDbEventCategories_sourceType (3.78s)

data "aws_db_event_categories" "example" {}
`

var completeEventCategoriesList = []string{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future maintainability note: this testing will break if AWS ever introduces new event categories -- generally speaking it would be better to ensure these values are included at a minimum rather than equally

@bflad bflad added this to the v1.38.0 milestone Sep 26, 2018
@bflad bflad merged commit 11180f5 into hashicorp:master Sep 26, 2018
bflad added a commit that referenced this pull request Sep 26, 2018
@bflad
Copy link
Contributor

bflad commented Sep 26, 2018

This has been released in version 1.38.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Source for RDS Event Categories
3 participants