d/aws_vpc: allow for multiple cidr blocks

[kl4w]

Fixes #5042

Changes proposed in this pull request:

• allow for multiple cidr blocks

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsVpc_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsVpc_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpc_basic
--- PASS: TestAccDataSourceAwsVpc_basic (26.17s)
=== RUN   TestAccDataSourceAwsVpc_ipv6Associated
--- PASS: TestAccDataSourceAwsVpc_ipv6Associated (25.49s)
=== RUN   TestAccDataSourceAwsVpc_multipleCidr
--- PASS: TestAccDataSourceAwsVpc_multipleCidr (49.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	101.320s

[bflad]

LGTM with one small adjustment on merge, thanks @kl4w! 🚀

=== RUN   TestAccDataSourceAwsVpc_basic
--- PASS: TestAccDataSourceAwsVpc_basic (29.87s)
=== RUN   TestAccDataSourceAwsVpc_multipleCidr
--- PASS: TestAccDataSourceAwsVpc_multipleCidr (43.53s)

[bflad]

When using d.Set() with aggregate types (TypeList, TypeSet, TypeMap), we should perform error checking to prevent issues where the code is not properly able to set the Terraform state. e.g.

if err := d.Set("cidr_block_associations", cidrAssociations); err != nil {
  return fmt.Errorf("error setting cidr_block_associations: %s", err)
}

Luckily this was working just fine before so will adjust this on merge. 👍

[bflad]

This has been released in version 1.27.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!