Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARN to cognito_identity_pool #4719

Merged
merged 1 commit into from
Jun 2, 2018
Merged

Add ARN to cognito_identity_pool #4719

merged 1 commit into from
Jun 2, 2018

Conversation

bespokebob
Copy link
Contributor

Cognito Identity Pools, like most AWS resources, have an ARN in addition to their ID that is used by other AWS services as a reference.

Fixes #4703

Changes proposed in this pull request:

  • Add arn attribute to cognito_identity_pool

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoIdentityPool_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCognitoIdentityPool_basic -timeout 120m
=== RUN   TestAccAWSCognitoIdentityPool_basic
--- PASS: TestAccAWSCognitoIdentityPool_basic (23.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.956s

Cognito Identity Pools, like most AWS resources, have an ARN in addition to their ID that is used by other AWS services as a reference.

Resolves #4703
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 31, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/cognito labels Jun 2, 2018
@bflad bflad added this to the v1.22.0 milestone Jun 2, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @youngbob! 🚀

6 tests passed (all tests)
=== RUN   TestAccAWSCognitoIdentityPool_importBasic
--- PASS: TestAccAWSCognitoIdentityPool_importBasic (7.18s)
=== RUN   TestAccAWSCognitoIdentityPool_basic
--- PASS: TestAccAWSCognitoIdentityPool_basic (10.94s)
=== RUN   TestAccAWSCognitoIdentityPool_openidConnectProviderArns
--- PASS: TestAccAWSCognitoIdentityPool_openidConnectProviderArns (15.33s)
=== RUN   TestAccAWSCognitoIdentityPool_cognitoIdentityProviders
--- PASS: TestAccAWSCognitoIdentityPool_cognitoIdentityProviders (15.44s)
=== RUN   TestAccAWSCognitoIdentityPool_supportedLoginProviders
--- PASS: TestAccAWSCognitoIdentityPool_supportedLoginProviders (15.63s)
=== RUN   TestAccAWSCognitoIdentityPool_samlProviderArns
--- PASS: TestAccAWSCognitoIdentityPool_samlProviderArns (19.61s)

@bflad bflad merged commit 5ae5a54 into hashicorp:master Jun 2, 2018
bflad added a commit that referenced this pull request Jun 2, 2018
@bespokebob bespokebob deleted the cognito-identity-pool-arn branch June 4, 2018 15:32
@bflad
Copy link
Contributor

bflad commented Jun 5, 2018

This has been released in version 1.22.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cognito_identity_pool should export arn
2 participants