r/aws_sns_sms_preferences Fix documentation omission #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XS
hwrdprkns
force-pushed
the
b-sns-fix-sms-pref
branch
from
2e19cec to
91a51e9
Compare
ghost
added
size/XS
hwrdprkns
changed the title
hwrdprkns
force-pushed
the
b-sns-fix-sms-pref
branch
from
91a51e9 to
8127e86
Compare
ghost
added
size/XS
hwrdprkns
force-pushed
the
b-sns-fix-sms-pref
branch
from
8127e86 to
2453822
Compare
hwrdprkns
force-pushed
the
b-sns-fix-sms-pref
branch
from
2453822 to
74e8623
Compare
bflad
approved these changes
May 30, 2018
| @@ -19,6 +19,7 @@ BUG FIXES: | |||
| * resource/aws_budgets_budget: Force new resource when updating `name` [GH-4656] | |||
| * resource/aws_dms_endpoint: Additionally specify MongoDB connection info in the top-level API namespace to prevent issues connecting [GH-4636] | |||
| * resource/aws_rds_cluster: Prevent additional retry error during S3 import for IAM/S3 eventual consistency [GH-4683] | |||
| * resource/aws_sns_sms_preferences: Properly add SNS preferences to website docs [GH-4694] | |||
There was a problem hiding this comment.
FYI the maintainers usually manage the CHANGELOG and we generally do not denote documentation updates (as there are usually many more of these per release)
There was a problem hiding this comment.
Solid - my bad I just did it out of habit. Feel free to change it if you like!
bflad
added
documentation
|
This has been released in version 1.21.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r/sns_sms_peferencesis missing from the documentation and also the filename was spelled incorrectly.