Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_kinesis_stream: Fix missing encryption_type default #4575

Merged
merged 1 commit into from
May 23, 2018
Merged

resource/aws_kinesis_stream: Fix missing encryption_type default #4575

merged 1 commit into from
May 23, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 17, 2018 •
edited
Loading

Fixes #3566

Changes proposed in this pull request:

  • Ensure missing EncryptionType defaults to schema default

Output from acceptance testing:

9 tests passed (all tests)
=== RUN   TestAccAWSKinesisStream_basic
--- PASS: TestAccAWSKinesisStream_basic (75.17s)
=== RUN   TestAccAWSKinesisStream_importBasic
--- PASS: TestAccAWSKinesisStream_importBasic (76.07s)
=== RUN   TestAccAWSKinesisStream_encryptionWithoutKmsKeyThrowsError
--- PASS: TestAccAWSKinesisStream_encryptionWithoutKmsKeyThrowsError (85.20s)
=== RUN   TestAccAWSKinesisStream_retentionPeriod
--- PASS: TestAccAWSKinesisStream_retentionPeriod (122.05s)
=== RUN   TestAccAWSKinesisStream_shardLevelMetrics
--- PASS: TestAccAWSKinesisStream_shardLevelMetrics (142.56s)
=== RUN   TestAccAWSKinesisStream_shardCount
--- PASS: TestAccAWSKinesisStream_shardCount (158.50s)
=== RUN   TestAccAWSKinesisStream_encryption
--- PASS: TestAccAWSKinesisStream_encryption (190.56s)
=== RUN   TestAccAWSKinesisStreamDataSource
--- PASS: TestAccAWSKinesisStreamDataSource (227.80s)
=== RUN   TestAccAWSKinesisStream_createMultipleConcurrentStreams
--- PASS: TestAccAWSKinesisStream_createMultipleConcurrentStreams (286.10s)

@bflad bflad added bug Addresses a defect in current functionality. service/kinesis Issues and PRs that pertain to the kinesis service. partition/aws-cn Pertains to the aws-cn partition. labels May 17, 2018
@bflad bflad added this to the v1.20.0 milestone May 17, 2018
@bflad bflad requested a review from a team May 17, 2018 23:10
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label May 17, 2018
@bflad bflad mentioned this pull request May 17, 2018
Closed
mbfrahry
mbfrahry approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 1314a43 into master May 23, 2018
@bflad bflad deleted the b-aws_kinesis_stream-encryption-default branch May 23, 2018 13:51
bflad added a commit that referenced this pull request May 23, 2018
@bflad
Update CHANGELOG for #4575
3112fef
@bflad
Copy link
Contributor Author

bflad commented May 23, 2018

This has been released in version 1.20.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. partition/aws-cn Pertains to the aws-cn partition. service/kinesis Issues and PRs that pertain to the kinesis service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

Kinesis stream bug in China AWS
2 participants
@bflad @mbfrahry