-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] res/vpc_peering_connection_accepter: add Importer #4486
[WIP] res/vpc_peering_connection_accepter: add Importer #4486
Conversation
Hi - has this been released or is there an ETA please ? |
While not necessary (can just apply it over the top) adding import would be a much nicer experience |
Would like to add to please DONT add the assertion against use with the same region/account as your "Question" implies. I'm using explicit accepter & separate option resources for a VPC module with combined peering I'm working on... Instead please just test/merge as is. |
Hi @Dominik-K 👋 Since we haven't seen any updates to this pull request in a very long time, we went ahead and finished the implementation (testing and documentation) in a followup commit. Thanks for your contribution! |
…ation Reference: #4486 Output from acceptance testing: ``` --- PASS: TestAccAWSVPCPeeringConnectionAccepter_sameRegionSameAccount (38.63s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_sameRegionDifferentAccount (39.03s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_differentRegionDifferentAccount (39.65s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_differentRegionSameAccount (42.12s) ```
This has been released in version 2.45.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Changes proposed in this pull request
import
functionality toaws_vpc_peering_connection_accepter
Questions
How to get the provider's
account_id
andregion
inside this code? I want to add a usage validating function that will check thatIf it's true, i.e. only VPC's differ, you'll need to use one
aws_vpc_peering_connection
instead. Otherwise the options on both resources can be ambiguous.Remarks
schema.ImportStatePassthrough
forces new resource on nextplan
. TheID
is the same on both sides of the peering connection.