Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_arn #3996

Merged
merged 1 commit into from
May 14, 2018
Merged

New Data Source: aws_arn #3996

merged 1 commit into from
May 14, 2018

Conversation

ewbankkit
Copy link
Contributor

Fixes #3995.
Add a data source that parses an Amazon Resource Name (ARN) into its constituent parts.

Acceptance tests:

make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsArn_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccDataSourceAwsArn_ -timeout 120m
=== RUN   TestAccDataSourceAwsArn_basic
--- PASS: TestAccDataSourceAwsArn_basic (12.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	12.510s

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Mar 30, 2018
@ewbankkit ewbankkit changed the title New Data Source: aws_arn' New Data Source: aws_arn Mar 30, 2018
@bflad bflad added new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 2, 2018
@bflad
Copy link
Contributor

bflad commented Apr 2, 2018

I'm asking for the use case in the original issue.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 2, 2018
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label May 14, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry in the delay in getting this merged. 😅

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsArn_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsArn_basic -timeout 120m
=== RUN   TestAccDataSourceAwsArn_basic
--- PASS: TestAccDataSourceAwsArn_basic (14.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.074s

@bflad bflad merged commit 7b888ee into hashicorp:master May 14, 2018
@bflad bflad added this to the v1.19.0 milestone May 14, 2018
bflad added a commit that referenced this pull request May 14, 2018
@bflad
Copy link
Contributor

bflad commented May 17, 2018

This has been released in version 1.19.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit deleted the issue-3995 branch May 18, 2018 22:00
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Data source to parse an ARN
2 participants