resource/cognito_user_pool_client: fix import with user pool id

[loivis]

fix #3753

When describing user pool client, user_pool_id is required.

1. Currently id is set as client_id, which makes it unable to import by default. Changing id to user_pool_id/client_id should be the best as I think. But that would be a breaking change?

2. Instead, I updated import function to parse user_pool_id and client_id during import.

[bflad]

Sorry for the delay in getting this reviewed 😅 could you take a look at removing the extra lookup in the import test?

[bflad]

We could shorten this lookup function if we set *client = ... in testAccCheckAWSCognitoUserPoolClientExists() from the return value of DescribeUserPoolClient()

Then we can simply grab the right IDs from an object we've already fetched in there 👍

[loivis]

Thanks for input. Not sure if I get your point exactly.

I've mostly copied the function and changed return values. Instead of parsing return value from DescribeUserPoolClient(), I directly return userPoolId and clientId set in DescribeUserPoolClientInput since there is error checking on DescribeUserPoolClient(). I assume that if there is no error then both IDs should be considered as valid.

[bflad]

Sorry I wasn't clear about what I meant earlier 😅 I can shorten it later. Let's get the more important fix in 🚀

3 tests passed (all tests)
=== RUN   TestAccAWSCognitoUserPoolClient_basic
--- PASS: TestAccAWSCognitoUserPoolClient_basic (8.12s)
=== RUN   TestAccAWSCognitoUserPoolClient_importBasic
--- PASS: TestAccAWSCognitoUserPoolClient_importBasic (8.48s)
=== RUN   TestAccAWSCognitoUserPoolClient_allFields
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (8.62s)

[bflad]

This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!