-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resource_aws_cognito_user_pool_client
to bind updates to callback_urls
to the correct param
#3404
Conversation
…llback_urls` to the correct param closes #3384
@radeksimko Any updates on this? |
@nick-woodward Did you get any feedback? I've run into this too. |
Nope, not sure what’s blocking this as it’s a fairly small change. It’s kinda unfortunate as this is a blocker for even using the new functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay in getting this trivial PR reviewed. 😖 Thanks for this contribution!
Normally we'd be looking for an acceptance test that is broken before the code change (e.g. in this case, taking TestAccAWSCognitoUserPoolClient_allFields
and adding a TestStep that updates at least this attribute in a new test configuration) then works afterwards, but in an effort to not break some other PRs behind this one and given its trivial fix nature, I'm going to merge this in as-is.
2 tests passed (all tests)
=== RUN TestAccAWSCognitoUserPoolClient_allFields
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (8.35s)
=== RUN TestAccAWSCognitoUserPoolClient_basic
--- PASS: TestAccAWSCognitoUserPoolClient_basic (8.50s)
This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Description
Fixes an issue where it was impossible to update a
resource_aws_cognito_user_pool_client
.I'm not overly familiar with go, so I don't really know the best way to regression test this.
Related Issues
closes #3384