resource/aws_instance: Expose reason of 'shutting-down' during creation

[radeksimko]

This is to improve the following message:

=== RUN   TestAccAWSSSMAssociation_basic
--- FAIL: TestAccAWSSSMAssociation_basic (71.48s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_instance.foo: 1 error(s) occurred:
        
        * aws_instance.foo: Error waiting for instance (i-0d22a4b3d279c4f44) to become ready: unexpected state 'shutting-down', wanted target 'running'. last error: %!s(<nil>)
    testing.go:573: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Check failed: Default error in SSM Association Test
        
        State: <no state>

It probably won't be much more helpful for the user in all cases, in our case above it was specifically Server.InternalError: Internal error on launch 🤷‍♂️ Either way all we can/should do is to expose whatever the API exposes.

[bflad]

LGTM -- this is actually super helpful because I was going to check to see if we just had a colliding sweeper with the test run

[bflad]

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!