resource/aws_vpc_endpoint: Treat pending as expected state during deletion

[radeksimko]

This is to address the following test failures:

=== RUN   TestAccAwsVpcEndpointSubnetAssociation_basic
--- FAIL: TestAccAwsVpcEndpointSubnetAssociation_basic (109.96s)
    testing.go:573: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Error applying: 1 error(s) occurred:
        
        * aws_vpc_endpoint.ec2 (destroy): 1 error(s) occurred:
        
        * aws_vpc_endpoint.ec2: Error waiting for VPC Endpoint vpce-0de87e4d69ceff0c0 to delete: unexpected state 'pending', wanted target 'deleted'. last error: %!s(<nil>)

=== RUN   TestAccAwsVpcEndpoint_gatewayWithRouteTableAndPolicy
--- FAIL: TestAccAwsVpcEndpoint_gatewayWithRouteTableAndPolicy (736.16s)
    testing.go:513: Step 1 error: Expected a non-empty plan, but got an empty plan!
FAIL

The second test was failing since the test step was introduced in 6876bf7#diff-1b6af3d3ebf63b2a6cae2399a0681cadR79. I assume it was just overlooked in such a large-scope PR.

Test results

=== RUN   TestAccAwsVpcEndpointConnectionNotification_importBasic
--- PASS: TestAccAwsVpcEndpointConnectionNotification_importBasic (290.04s)
=== RUN   TestAccAwsVpcEndpointService_importBasic
--- PASS: TestAccAwsVpcEndpointService_importBasic (298.93s)
=== RUN   TestAccAwsVpcEndpoint_importBasic
--- PASS: TestAccAwsVpcEndpoint_importBasic (85.44s)
=== RUN   TestAccAwsVpcEndpointConnectionNotification_basic
--- PASS: TestAccAwsVpcEndpointConnectionNotification_basic (334.46s)
=== RUN   TestAccAwsVpcEndpointRouteTableAssociation_basic
--- PASS: TestAccAwsVpcEndpointRouteTableAssociation_basic (79.16s)
=== RUN   TestAccAwsVpcEndpointServiceAllowedPrincipal_basic
--- PASS: TestAccAwsVpcEndpointServiceAllowedPrincipal_basic (285.35s)
=== RUN   TestAccAwsVpcEndpointService_basic
--- PASS: TestAccAwsVpcEndpointService_basic (518.51s)
=== RUN   TestAccAwsVpcEndpointService_removed
--- PASS: TestAccAwsVpcEndpointService_removed (276.15s)
=== RUN   TestAccAwsVpcEndpointSubnetAssociation_basic
--- PASS: TestAccAwsVpcEndpointSubnetAssociation_basic (108.20s)
=== RUN   TestAccAwsVpcEndpoint_gatewayBasic
--- PASS: TestAccAwsVpcEndpoint_gatewayBasic (76.45s)
=== RUN   TestAccAwsVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAwsVpcEndpoint_gatewayWithRouteTableAndPolicy (138.08s)
=== RUN   TestAccAwsVpcEndpoint_interfaceBasic
--- PASS: TestAccAwsVpcEndpoint_interfaceBasic (80.84s)
=== RUN   TestAccAwsVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAwsVpcEndpoint_interfaceWithSubnetAndSecurityGroup (320.24s)
=== RUN   TestAccAwsVpcEndpoint_interfaceNonAWSService
--- PASS: TestAccAwsVpcEndpoint_interfaceNonAWSService (320.66s)
=== RUN   TestAccAwsVpcEndpoint_removed
--- PASS: TestAccAwsVpcEndpoint_removed (62.88s)

cc @ewbankkit @jen20

[bflad]

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!