f/instance d/instance: Get (Windows) password data #2219

meyertime · 2017-11-08T19:07:31Z

This is one half of the puzzle which was previously hashicorp/terraform#5675.

This addresses issue hashicorp/terraform#3148 which was moved to #30.

Basically, when an instance is read from AWS (either an instance resource or data source), you now have the option to read the encrypted password data as well. Since not all instances will have password data and it takes time for that data to become available, retrieving this data is optional based on the value of get_password_data, which defaults to false. When true, a password_data attribute is populated with the encrypted data.

This PR is ready to merge, containing updated docs and working acceptance tests. I chose the latest Windows Server 2016 Core image for the tests, since it boots the fastest (and thus the password data becomes available the quickest).

The other half of the puzzle will be decrypting this password data. This will involve implementing built-in functions in Terraform proper to enable this decryption using an interpolated string.

smastrorocco · 2017-11-09T18:05:17Z

+1 Would really like to see this merged

meyertime · 2017-11-14T18:28:47Z

The second half of this is ready now: hashicorp/terraform#16647

meyertime · 2017-12-22T17:08:08Z

Can I get a merge here? The necessary rsadecrypt function has been merged. Once this PR is merged and both are released, we can do secure Windows provisioning in AWS like this:

resource "aws_instance" "foo" {
  get_password_data = true
  ...

  connection {
    password = "${rsadecrypt(self.password_data, file("/path/to/private_key.pem"))}"
    ...
  }
}

And/or:

resource "null_resource" "foo" {
  ...

  connection {
    password = "${rsadecrypt(aws_instance.foo.password_data, file("/path/to/private_key.pem"))}"
    ...
  }
}

Or:

data "aws_instance" "foo" {
  get_password_data = true
  ...
}

resource "null_resource" "foo" {
  ...

  connection {
    password = "${rsadecrypt(data.aws_instance.foo.password_data, file("/path/to/private_key.pem"))}"
    ...
  }
}

jakemig · 2018-01-10T15:16:44Z

I'd also love to see this functionality in the AWS provider.

itsamenathan · 2018-01-10T15:52:55Z

I would love to see this as well. Looks like the other half of this merge has landed in core as of yesterday.

grig-tar · 2018-01-12T08:16:53Z

When you planning to merge this PR?

jeremygaither · 2018-01-12T22:25:07Z

I also need this...

bflad

Hi @deftflux, thanks so much for submitting this (twice!). Its obviously been a long time coming for a PR review 😅 sorry about the lengthy delay. The PR is in actually pretty good shape but I left a few initial review notes. Can you take a look through them, let me know if you have any questions, and when it can be looked at again? 🚀

bflad · 2018-02-06T03:11:13Z

aws/resource_aws_instance.go

+
+	log.Printf("[INFO] Reading password data for instance %s", d.Id())
+
+	timeout := time.Now().Add(15 * time.Minute)


Nitpick: we have the resource.Retry function we regularly use for these type of retryable operations:

var passwordData string input := &ec2.GetPasswordDataInput{ InstanceId: aws.String(instanceID), } err := resource.Retry(15 * time.Minute, func() *resource.RetryError { out, err := conn.GetPasswordData(input) if err != nil { return resource.NonRetryableError(err) } if resp.PasswordData == nil || *resp.PasswordData == "" { return resource.RetryableError(fmt.Errorf("Password data is blank for instance ID: %s", instanceID)) } passwordData = strings.TrimSpace(*resp.PasswordData) return nil }) if err != nil { return "", err } return passwordData, nil

bflad · 2018-02-06T03:13:57Z

aws/resource_aws_instance.go

@@ -1528,6 +1543,46 @@ func readSecurityGroups(d *schema.ResourceData, instance *ec2.Instance, conn *ec
 	return nil
 }

+func readPasswordData(d *schema.ResourceData, instance *ec2.Instance, conn *ec2.EC2) error {


We should try to reduce this function's signature to one action and leave the state management outside of this function, e.g.

func getAwsEc2InstancePasswordData(instanceID string, conn *ec2.EC2) (string, error)

bflad · 2018-02-06T03:17:25Z

aws/resource_aws_instance.go

@@ -1528,6 +1543,46 @@ func readSecurityGroups(d *schema.ResourceData, instance *ec2.Instance, conn *ec
 	return nil
 }

+func readPasswordData(d *schema.ResourceData, instance *ec2.Instance, conn *ec2.EC2) error {
+	if !d.Get("get_password_data").(bool) {
+		if err := d.Set("password_data", nil); err != nil {


When using d.Set() with *string, we do not need the additional err checking. 👍

bflad · 2018-02-06T03:20:04Z

aws/resource_aws_instance_test.go

+func testAccInstanceConfig_getPasswordData(val bool) string {
+	return fmt.Sprintf(`
+	resource "aws_key_pair" "foo" {
+		key_name = "tf-acc-winpasswordtest"


The key name needs to be randomized for parallel or broken test runs. key_name = "tf-acc-%d" (where %d can come from the top level test function, e.g. rInt := acctest.RandInt()

bflad · 2018-02-06T03:21:11Z

aws/data_source_aws_instance_test.go

+func testAccInstanceDataSourceConfig_getPasswordData(val bool) string {
+	return fmt.Sprintf(`
+	resource "aws_key_pair" "foo" {
+		key_name = "tf-acc-winpasswordtest"


The key name needs to be randomized for parallel or broken test runs. key_name = "tf-acc-%d" (where %d can come from the top level test function, e.g. rInt := acctest.RandInt()

bflad · 2018-02-06T03:23:47Z

aws/data_source_aws_instance_test.go

@@ -216,6 +216,84 @@ func TestAccAWSInstanceDataSource_VPCSecurityGroups(t *testing.T) {
 	})
 }

+func TestAccAWSInstanceDataSource_getPasswordData_true(t *testing.T) {


Can we reduce these down to two acceptance tests please? true -> false and false -> true should be sufficient

bflad · 2018-02-06T03:25:45Z

aws/resource_aws_instance_test.go

@@ -1288,6 +1288,108 @@ func TestAccAWSInstance_associatePublic_overridePrivate(t *testing.T) {
 	})
 }

+func TestAccAWSInstance_getPasswordData_true(t *testing.T) {


Can we reduce this down to two acceptance tests please? false -> true and true -> false should be sufficient

bflad · 2018-02-06T03:43:21Z

website/docs/r/instance.html.markdown

@@ -64,6 +64,7 @@ instance. Amazon defaults this to `stop` for EBS-backed instances and
 instances. See [Shutdown Behavior](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/terminating-instances.html#Using_ChangingInstanceInitiatedShutdownBehavior) for more information.
 * `instance_type` - (Required) The type of instance to start
 * `key_name` - (Optional) The key name to use for the instance.
+* `get_password_data` - (Optional) If true, wait for password data to become available and retrieve it.  The password data is exported to the `password_data` attribute.


For all mentions, we should specifically add Microsoft Windows in the documentation and potentially link to the API documentation: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_GetPasswordData.html

joeabbey · 2018-03-01T03:28:50Z

👍 Would love to see this merged

meyertime · 2018-03-08T04:17:19Z

Thanks for the feedback, @bflad. It took a while to get around to making the changes and testing, but it's done now. Please review.

bflad

This is almost ready! One last thing:

=== RUN   TestAccAWSInstance_importBasic
--- FAIL: TestAccAWSInstance_importBasic (578.44s)
    testing.go:513: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "get_password_data": (string) (len=5) "false"
        }

=== RUN   TestAccAWSInstance_importInDefaultVpcBySgId
--- FAIL: TestAccAWSInstance_importInDefaultVpcBySgId (290.35s)
    testing.go:513: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "get_password_data": (string) (len=5) "false"
        }

=== RUN   TestAccAWSInstance_importInEc2Classic
--- FAIL: TestAccAWSInstance_importInEc2Classic (109.72s)
    testing.go:513: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "get_password_data": (string) (len=5) "false"
        }

It just needs d.Set("get_password_data", ...) called during the read function so importing an instance doesn't show that as a difference.

discentem · 2018-03-13T00:14:14Z

This might be a little off-topic, but does terraform support winrm over https? Tangentially related to this PR, which improves Windows/AWS/Terraform support.

bflad · 2018-03-13T10:44:13Z

@discentem: There is a https flag for WinRM connections: https://www.terraform.io/docs/provisioners/connection.html#https

meyertime · 2018-03-13T15:54:31Z

@discentem a little off-topic, but yes. However, it does require some magic sauce in the user data to set up WinRM over HTTPS on the instance, unless you're using an AMI that already has this set up. The built-in Windows AMI's provided by Amazon do not have WinRM set up at all. Setting up HTTPS also requires generating a certificate within that user data script.

Here's some magic sauce:

<powershell>

echo "Generate certificate for WinRM"
$cert = New-SelfSignedCertificate -CertStoreLocation cert:\LocalMachine\My -DnsName $env:computername
$thumb = $cert.Thumbprint

echo "Enable WinRM"
winrm quickconfig -q
winrm set winrm/config '@{MaxTimeoutms="1800000"}'
winrm set winrm/config/winrs '@{MaxMemoryPerShellMB="300"}'
winrm set winrm/config/service/auth '@{Basic="true"}'
winrm create winrm/config/listener?Address=*+Transport=HTTPS "@{CertificateThumbprint=`"$thumb`";Port=`"5986`"}"

echo "Enable WinRM firewall rules"
if ((get-service -DisplayName "Windows Firewall").StartType -ne "Disabled") {
	Remove-NetFirewallRule -DisplayName "WinRM" -ErrorAction SilentlyContinue
	New-NetFirewallRule -DisplayName "WinRM" -Direction Inbound -Protocol TCP -LocalPort 5986 | Out-Null
}

echo "Restart WinRM service"
Stop-Service winrm
Set-Service winrm -StartupType Automatic
Start-Service winrm

echo "Finished PowerShell script"

</powershell>

Same thing is required when using Packer to build an image. Also, since this uses a self-signed cert, the insecure flag is required as well.

meyertime · 2018-03-13T16:52:37Z

@bflad Not sure how to bounce this back to you, but I made the requested change. The tests should pass now.

bflad

This looks great -- thanks so much for this contribution! 🎉 🚀

 61 tests passed (all tests)
=== RUN   TestAccAWSInstanceDataSource_keyPair
--- PASS: TestAccAWSInstanceDataSource_keyPair (87.12s)
=== RUN   TestAccAWSInstanceDataSource_SecurityGroups
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (182.30s)
=== RUN   TestAccAWSInstance_importInDefaultVpcBySgName
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgName (205.71s)
=== RUN   TestAccAWSInstanceDataSource_rootInstanceStore
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (251.71s)
=== RUN   TestAccAWSInstanceDataSource_privateIP
--- PASS: TestAccAWSInstanceDataSource_privateIP (255.15s)
=== RUN   TestAccAWSInstancesDataSource_basic
--- PASS: TestAccAWSInstancesDataSource_basic (277.11s)
=== RUN   TestAccAWSInstance_importInDefaultVpcBySgId
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgId (279.31s)
=== RUN   TestAccAWSInstancesDataSource_tags
--- PASS: TestAccAWSInstancesDataSource_tags (310.58s)
=== RUN   TestAccAWSInstanceDataSource_PlacementGroup
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (320.15s)
=== RUN   TestAccAWSInstance_GP2IopsDevice
--- PASS: TestAccAWSInstance_GP2IopsDevice (134.02s)
=== RUN   TestAccAWSInstanceDataSource_VPCSecurityGroups
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (361.57s)
=== RUN   TestAccAWSInstance_importBasic
--- PASS: TestAccAWSInstance_importBasic (369.00s)
=== RUN   TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_blockDevices (120.83s)
=== RUN   TestAccAWSInstanceDataSource_gp2IopsDevice
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (383.42s)
=== RUN   TestAccAWSInstance_noAMIEphemeralDevices
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (113.28s)
=== RUN   TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_basic (305.76s)
=== RUN   TestAccAWSInstanceDataSource_tags
--- PASS: TestAccAWSInstanceDataSource_tags (407.71s)
=== RUN   TestAccAWSInstanceDataSource_basic
--- PASS: TestAccAWSInstanceDataSource_basic (417.96s)
=== RUN   TestAccAWSInstance_userDataBase64
--- PASS: TestAccAWSInstance_userDataBase64 (262.84s)
=== RUN   TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (127.04s)
=== RUN   TestAccAWSInstance_placementGroup
--- PASS: TestAccAWSInstance_placementGroup (176.61s)
=== RUN   TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_vpc (205.03s)
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (594.24s)
=== RUN   TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_rootInstanceStore (346.69s)
=== RUN   TestAccAWSInstanceDataSource_AzUserData
--- PASS: TestAccAWSInstanceDataSource_AzUserData (631.28s)
=== RUN   TestAccAWSInstanceDataSource_blockDevices
--- PASS: TestAccAWSInstanceDataSource_blockDevices (639.29s)
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (641.53s)
=== RUN   TestAccAWSInstance_multipleRegions
--- PASS: TestAccAWSInstance_multipleRegions (252.68s)
=== RUN   TestAccAWSInstance_tags
--- PASS: TestAccAWSInstance_tags (215.91s)
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (251.93s)
=== RUN   TestAccAWSInstance_volumeTagsComputed
--- PASS: TestAccAWSInstance_volumeTagsComputed (144.39s)
=== RUN   TestAccAWSInstance_instanceProfileChange
--- PASS: TestAccAWSInstance_instanceProfileChange (197.58s)
=== RUN   TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (340.99s)
=== RUN   TestAccAWSInstance_keyPairCheck
--- PASS: TestAccAWSInstance_keyPairCheck (110.85s)
=== RUN   TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_sourceDestCheck (457.59s)
=== RUN   TestAccAWSInstance_withIamInstanceProfile
--- PASS: TestAccAWSInstance_withIamInstanceProfile (238.95s)
=== RUN   TestAccAWSInstance_primaryNetworkInterface
--- PASS: TestAccAWSInstance_primaryNetworkInterface (214.25s)
=== RUN   TestAccAWSInstance_GP2WithIopsValue
--- PASS: TestAccAWSInstance_GP2WithIopsValue (650.03s)
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (301.50s)
=== RUN   TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_disableApiTermination (618.64s)
=== RUN   TestAccAWSInstanceDataSource_VPC
--- PASS: TestAccAWSInstanceDataSource_VPC (962.61s)
=== RUN   TestAccAWSInstance_associatePublic_defaultPublic
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (198.08s)
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (587.44s)
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (292.45s)
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (371.37s)
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (184.21s)
=== RUN   TestAccAWSInstance_volumeTags
--- PASS: TestAccAWSInstance_volumeTags (545.44s)
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (432.28s)
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (216.12s)
=== RUN   TestAccAWSInstance_associatePublic_overridePublic
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (204.65s)
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (185.09s)
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (800.62s)
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (789.77s)
=== RUN   TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_privateIP (564.16s)
=== RUN   TestAccAWSInstance_associatePublic_defaultPrivate
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (462.32s)
=== RUN   TestAccAWSInstance_addSecurityGroupNetworkInterface
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (466.05s)
=== RUN   TestAccAWSInstance_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (355.86s)
=== RUN   TestAccAWSInstance_importInEc2Classic
--- PASS: TestAccAWSInstance_importInEc2Classic (1345.27s)
=== RUN   TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_changeInstanceType (698.59s)
=== RUN   TestAccAWSInstance_addSecondaryInterface
--- PASS: TestAccAWSInstance_addSecondaryInterface (618.78s)
=== RUN   TestAccAWSInstance_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (573.26s)

meyertime · 2018-03-13T18:43:40Z

👍 🎉

jeremygaither · 2018-03-18T16:21:53Z

@deftflux THANK YOU!

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉

discentem · 2018-03-18T16:48:10Z

Anyone willing to post instructions on overriding the released aws provider with a build that includes these changes? I built it, dropped it into ~/.terraform.d/plugins/, ran terraform init (no changes), but terraform still doesn't recognize get_password_data.

discentem · 2018-03-18T19:09:52Z

I pieced it together. A bit complicated though. It seems terraform doesn't respect a higher z value when parsing plugin_vx.y.z. Had to bump y by 1.

bflad · 2018-03-23T21:08:15Z

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

discentem · 2018-03-24T19:58:35Z

Thanks @bflad. I found the docs for specifying the version in the provider code 👍

bodgit · 2018-04-12T12:47:47Z

I don't think this was implemented for spot requests so it's breaks if you try and spin up a Windows instance as a spot request and try and access the password data. I'll see about creating a PR to fix this.

midacts · 2019-04-11T16:49:10Z

Does anyone know if this is documented anywhere? Maybe in the aws_instance resource docs?
The solution to this problem was not easy to find.

ghost · 2020-03-30T17:43:51Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

David Meyer added 2 commits November 8, 2017 12:10

r/instance d/instance: Get (Windows) password data.

8b01af5

d/instance: Acceptance tests for getting password data.

fe12cd7

This was referenced Nov 8, 2017

aws_instance: set windows_password attr on windows instances #30

Closed

Use password data facility in AWS for provisioning (issue #3148) hashicorp/terraform#5675

Closed

Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 8, 2017

meyertime mentioned this pull request Nov 14, 2017

Interpolation functions rsaencrypt and rsadecrypt hashicorp/terraform#16647

Merged

radeksimko added the size/L Managed by automation to categorize the size of a PR. label Nov 15, 2017

bflad added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jan 28, 2018

bflad reviewed Feb 6, 2018

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Feb 6, 2018

PR feedback tweaks.

9124635

ghost added the size/L Managed by automation to categorize the size of a PR. label Mar 8, 2018

bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 8, 2018

bflad self-requested a review March 8, 2018 15:10

bflad suggested changes Mar 9, 2018

View reviewed changes

bflad added this to the v1.12.0 milestone Mar 9, 2018

Fix instance import.

9d94d53

ghost added the size/L Managed by automation to categorize the size of a PR. label Mar 13, 2018

bflad self-requested a review March 13, 2018 17:09

bflad approved these changes Mar 13, 2018

View reviewed changes

bflad merged commit 8d6c848 into hashicorp:master Mar 13, 2018

bflad added a commit that referenced this pull request Mar 13, 2018

Update CHANGELOG for #2219

8b5d1a2

bodgit mentioned this pull request Apr 12, 2018

Support password data on spot requests #4189

Merged

discentem mentioned this pull request May 10, 2018

No support for Automated Windows Password generation hashicorp/terraform-provider-google#1472

Closed

ghost locked and limited conversation to collaborators Mar 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

f/instance d/instance: Get (Windows) password data #2219

f/instance d/instance: Get (Windows) password data #2219

meyertime commented Nov 8, 2017

smastrorocco commented Nov 9, 2017

meyertime commented Nov 14, 2017

meyertime commented Dec 22, 2017

jakemig commented Jan 10, 2018

itsamenathan commented Jan 10, 2018

grig-tar commented Jan 12, 2018

jeremygaither commented Jan 12, 2018

bflad left a comment

bflad Feb 6, 2018

bflad Feb 6, 2018

bflad Feb 6, 2018

bflad Feb 6, 2018

bflad Feb 6, 2018

bflad Feb 6, 2018

bflad Feb 6, 2018

bflad Feb 6, 2018

joeabbey commented Mar 1, 2018

meyertime commented Mar 8, 2018

bflad left a comment •

edited

Loading

discentem commented Mar 13, 2018 •

edited

Loading

bflad commented Mar 13, 2018

meyertime commented Mar 13, 2018

meyertime commented Mar 13, 2018

bflad left a comment

meyertime commented Mar 13, 2018

jeremygaither commented Mar 18, 2018

discentem commented Mar 18, 2018 •

edited

Loading

discentem commented Mar 18, 2018

bflad commented Mar 23, 2018

discentem commented Mar 24, 2018

bodgit commented Apr 12, 2018

midacts commented Apr 11, 2019

ghost commented Mar 30, 2020


		log.Printf("[INFO] Reading password data for instance %s", d.Id())

		timeout := time.Now().Add(15 * time.Minute)

f/instance d/instance: Get (Windows) password data #2219

f/instance d/instance: Get (Windows) password data #2219

Conversation

meyertime commented Nov 8, 2017

smastrorocco commented Nov 9, 2017

meyertime commented Nov 14, 2017

meyertime commented Dec 22, 2017

jakemig commented Jan 10, 2018

itsamenathan commented Jan 10, 2018

grig-tar commented Jan 12, 2018

jeremygaither commented Jan 12, 2018

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joeabbey commented Mar 1, 2018

meyertime commented Mar 8, 2018

bflad left a comment • edited Loading

Choose a reason for hiding this comment

discentem commented Mar 13, 2018 • edited Loading

bflad commented Mar 13, 2018

meyertime commented Mar 13, 2018

meyertime commented Mar 13, 2018

bflad left a comment

Choose a reason for hiding this comment

meyertime commented Mar 13, 2018

jeremygaither commented Mar 18, 2018

discentem commented Mar 18, 2018 • edited Loading

discentem commented Mar 18, 2018

bflad commented Mar 23, 2018

discentem commented Mar 24, 2018

bodgit commented Apr 12, 2018

midacts commented Apr 11, 2019

ghost commented Mar 30, 2020

bflad left a comment •

edited

Loading

discentem commented Mar 13, 2018 •

edited

Loading

discentem commented Mar 18, 2018 •

edited

Loading