Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SQS queue tags #1987

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Add support for SQS queue tags #1987

merged 1 commit into from
Oct 27, 2017

Conversation

ewbankkit
Copy link
Contributor

Fixes #1983.

Acceptance tests:

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSQSQueue_tags'==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSSQSQueue_tags -timeout 120m
=== RUN   TestAccAWSSQSQueue_tags
--- PASS: TestAccAWSSQSQueue_tags (39.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.549s

Ensure no regression:

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSQSQueue_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSSQSQueue_basic -timeout 120m
=== RUN   TestAccAWSSQSQueue_basic
--- PASS: TestAccAWSSQSQueue_basic (38.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.170s

@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 21, 2017
radeksimko
radeksimko approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

aws/resource_aws_sqs_queue.go
"content_based_deduplication": "ContentBasedDeduplication",
"kms_master_key_id": "KmsMasterKeyId",
"kms_data_key_reuse_period_seconds": "KmsDataKeyReusePeriodSeconds",
var sqsQueueAttributeMap = map[string]string{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate this cleanup 👍

@radeksimko radeksimko merged commit 39611c5 into hashicorp:master Oct 27, 2017
@ewbankkit ewbankkit deleted the issue-1983 branch October 27, 2017 18:49
@AntonBazhal
Copy link

@ewbankkit @radeksimko This introduced breaking change to the plugin, since it requires "sqs:ListQueueTags" permission to be added to IAM policy.

@ewbankkit
Copy link
Contributor Author

@AntonBazhal Yes, that was something I had thought about and we hit a similar thing with KMS tags - hashicorp/terraform#12243. I'm still not sure there's an "official" way of dealing with these.

@AntonBazhal
Copy link

@ewbankkit The main problem is that this was released with a minor version bump and I spent half a day today trying to understand why all our builds started to fail, even though everything was OK yesterday.

@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for SQS Queue tagging
3 participants
@ewbankkit @AntonBazhal @radeksimko