Add Outpost and COIP support to aws_lb datasource and resource

[johnbarney]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15147

Release note for CHANGELOG:

Add aws_lb resource support for AWS Outpost
Add aws_lb resource support for customer owned IPv4 pools
Add aws_lb datasource support for AWS Outpost
Add aws_lb datasource support for customer owned IPv4 pools

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAWSLB_outpost'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSLB_outpost -timeout 120m
=== RUN   TestAccDataSourceAWSLB_outpost
=== PAUSE TestAccDataSourceAWSLB_outpost
=== CONT  TestAccDataSourceAWSLB_outpost
--- PASS: TestAccDataSourceAWSLB_outpost (284.49s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       284.548s

$ make testacc TESTARGS='-run=TestAccAWSLB_ALB_outpost'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLB_ALB_outpost -timeout 120m
=== RUN   TestAccAWSLB_ALB_outpost
=== PAUSE TestAccAWSLB_ALB_outpost
=== CONT  TestAccAWSLB_ALB_outpost
--- PASS: TestAccAWSLB_ALB_outpost (303.49s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       303.550s
...

[johnbarney]

Additional note: During regression testing I found the aws_lb datasource tests fail due to a failure to find aws_lb by name. Seemed unrelated to my changes. If I'm incorrect please let me know.

[bflad]

Thank you for submitting this, @johnbarney 👍 Just some minor items then can run the regression testing.

[johnbarney]

Tested suggested changes. All working on Outpost.

[bflad]

Looks great, thanks again, @johnbarney 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLB_ALB_AccessLogs (330.97s)
--- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (289.97s)
--- PASS: TestAccAWSLB_ALB_basic (171.36s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (265.58s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDropInvalidHeaderFields (310.11s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (309.72s)
--- PASS: TestAccAWSLB_BackwardsCompatibility (200.44s)
--- PASS: TestAccAWSLB_generatedName (181.76s)
--- PASS: TestAccAWSLB_generatesNameForZeroValue (203.03s)
--- PASS: TestAccAWSLB_namePrefix (193.55s)
--- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (249.40s)
--- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (370.27s)
--- PASS: TestAccAWSLB_networkLoadbalancerEIP (235.19s)
--- PASS: TestAccAWSLB_NLB_AccessLogs (405.81s)
--- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (353.28s)
--- PASS: TestAccAWSLB_NLB_basic (229.87s)
--- PASS: TestAccAWSLB_NLB_privateipv4address (270.50s)
--- PASS: TestAccAWSLB_noSecurityGroup (181.45s)
--- PASS: TestAccAWSLB_tags (287.41s)
--- PASS: TestAccAWSLB_updatedIpAddressType (302.71s)
--- PASS: TestAccAWSLB_updatedSecurityGroups (247.78s)
--- PASS: TestAccAWSLB_updatedSubnets (234.88s)
--- SKIP: TestAccAWSLB_ALB_outpost (1.85s)

--- PASS: TestAccDataSourceAWSLB_BackwardsCompatibility (199.82s)
--- PASS: TestAccDataSourceAWSLB_basic (203.26s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (197.09s)
--- PASS: TestAccDataSourceAWSLBListener_basic (182.14s)
--- PASS: TestAccDataSourceAWSLBListener_https (263.19s)
--- PASS: TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility (206.24s)
--- SKIP: TestAccDataSourceAWSLB_outpost (1.95s)

[ghost]

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!