Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_data_catalog_encryption_settings - new resource #14916

Merged
merged 10 commits into from
Oct 1, 2020
Merged

r/glue_data_catalog_encryption_settings - new resource #14916

merged 10 commits into from
Oct 1, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9736

Release note for CHANGELOG:

resource_aws_glue_data_catalog_encryption_settings - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (129.39s)

@DrFaust92 DrFaust92 requested a review from a team August 30, 2020 18:11
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 30, 2020
@DrFaust92 DrFaust92 mentioned this pull request Aug 30, 2020
Closed
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Aug 30, 2020
@DrFaust92 DrFaust92 force-pushed the r/glue_data_catalog_encryption_settings branch from 17df8ab to 737b0e7 Compare September 24, 2020 14:24
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN   TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT  TestAccAWSDataCatalogEncryptionSettings_basic
--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (44.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.672s

@DrFaust92 DrFaust92 force-pushed the r/glue_data_catalog_encryption_settings branch from 737b0e7 to 2ede994 Compare September 30, 2020 08:46
@ewbankkit
Copy link
Contributor

@DrFaust92 Acceptance test failure:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN   TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT  TestAccAWSDataCatalogEncryptionSettings_basic
    resource_aws_glue_data_catalog_encryption_settings_test.go:21: Check 5/8 error: aws_glue_data_catalog_encryption_settings.test: Attribute 'data_catalog_encryption_settings.0.connection_password_encryption.0.aws_kms_id' not found
--- FAIL: TestAccAWSDataCatalogEncryptionSettings_basic (7.86s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	7.905s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1

@DrFaust92
Copy link
Collaborator Author

missed replaces in tests, sorry.

@DrFaust92
Copy link
Collaborator Author

--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (103.66s)

ewbankkit
ewbankkit reviewed Oct 1, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN   TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT  TestAccAWSDataCatalogEncryptionSettings_basic
--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (45.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.158s

@breathingdust
Copy link
Member

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN   TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT  TestAccAWSDataCatalogEncryptionSettings_basic
--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (38.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.551s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN   TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT  TestAccAWSDataCatalogEncryptionSettings_basic
--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (28.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.332s

@breathingdust breathingdust added this to the v3.9.0 milestone Oct 1, 2020
@breathingdust breathingdust merged commit 03b3b8b into hashicorp:master Oct 1, 2020
breathingdust added a commit that referenced this pull request Oct 1, 2020
@breathingdust
Update CHANGELOG for #14916
6b7663c
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2020
@DrFaust92 DrFaust92 deleted the r/glue_data_catalog_encryption_settings branch April 15, 2021 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

Support for setting AWS Glue Data Catalog Encryption/settings
3 participants
@DrFaust92 @ewbankkit @breathingdust