Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-debt: update opsworks_slack attr and tests and enumerated values in opsworks resources #14886

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 28, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #8950, #14417, #14601

Release note for CHANGELOG:

resource/opsworks_slack: Add DiffSuppressFunc to custom_json argument
tech-debt: update opsworks_slack tests and enumerated values in opsworks_application and opsworks_instance resources

Output from acceptance testing:

--- PASS: TestAccAWSOpsworksStack_CustomCookbooks_SetPrivateProperties (30.24s)
--- PASS: TestAccAWSOpsworksStack_vpc (60.31s)
--- PASS: TestAccAWSOpsworksStack_noVpcBasic (24.57s)
--- PASS: TestAccAWSOpsworksMysqlLayer_basic (70.46s)
--- PASS: TestAccAWSOpsworksHAProxyLayer_basic (70.45s)
--- PASS: TestAccAWSOpsworksGangliaLayer_basic (83.00s)
--- PASS: TestAccAWSOpsworksMemcachedLayer_basic (83.36s)
--- PASS: TestAccAWSOpsworksJavaAppLayer_basic (88.66s)
--- PASS: TestAccAWSOpsworksNodejsAppLayer_basic (98.68s)
--- PASS: TestAccAWSOpsworksCustomLayer_basic (99.46s)
--- PASS: TestAccAWSOpsworksApplication_basic (123.79s)
--- PASS: TestAccAWSOpsworksInstance_UpdateHostNameForceNew (135.35s)
--- PASS: TestAccAWSOpsworksPermission_Self (135.47s)
--- PASS: TestAccAWSOpsworksCustomLayer_noVPC (140.08s)
--- PASS: TestAccAWSOpsworksInstance_basic (144.05s)
--- PASS: TestAccAWSOpsworksPhpAppLayer_basic (74.41s)
--- PASS: TestAccAWSOpsworksGangliaLayer_tags (160.73s)
--- PASS: TestAccAWSOpsworksHAProxyLayer_tags (169.59s)
--- PASS: TestAccAWSOpsworksMysqlLayer_tags (171.41s)
--- PASS: TestAccAWSOpsworksJavaAppLayer_tags (175.30s)
--- PASS: TestAccAWSOpsworksCustomLayer_tags (176.14s)
--- PASS: TestAccAWSOpsworksMemcachedLayer_tags (183.41s)
--- PASS: TestAccAWSOpsworksNodejsAppLayer_tags (184.67s)
--- PASS: TestAccAWSOpsworksRailsAppLayer_basic (107.00s)
--- PASS: TestAccAWSOpsworksPermission_basic (191.52s)
--- PASS: TestAccAWSOpsworksStaticWebLayer_basic (53.71s)
--- PASS: TestAccAWSOpsworksUserProfile_basic (57.25s)
--- PASS: TestAccAWSOpsworksPhpAppLayer_tags (135.82s)
--- PASS: TestAccAWSOpsworksStack_noVpcCreateTags (72.14s)
--- PASS: TestAccAWSOpsworksStack_noVpcChangeServiceRoleForceNew (108.44s)
--- PASS: TestAccAWSOpsworksRailsAppLayer_tags (125.30s)
--- PASS: TestAccAWSOpsworksStaticWebLayer_tags (81.18s)
--- PASS: TestAccAWSOpsworksRdsDbInstance_basic (771.28s)

@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Aug 28, 2020
@anGie44 anGie44 requested a review from a team August 28, 2020 02:47
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/opsworks Issues and PRs that pertain to the opsworks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 28, 2020
@bflad bflad self-assigned this Aug 28, 2020
@anGie44 anGie44 requested a review from bflad August 28, 2020 15:11
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀 So many tests will be happier.

Output from acceptance testing:

--- PASS: TestAccAWSOpsworksStack_CustomCookbooks_SetPrivateProperties (41.17s)
--- PASS: TestAccAWSOpsworksStack_noVpcBasic (50.67s)
--- PASS: TestAccAWSOpsworksStack_vpc (59.69s)
--- PASS: TestAccAWSOpsworksApplication_basic (62.43s)
--- PASS: TestAccAWSOpsworksStack_noVpcCreateTags (64.25s)
--- PASS: TestAccAWSOpsworksInstance_UpdateHostNameForceNew (65.30s)
--- PASS: TestAccAWSOpsWorksStack_classicEndpoints (65.83s)
--- PASS: TestAccAWSOpsworksInstance_basic (66.11s)
--- PASS: TestAccAWSOpsworksStack_noVpcChangeServiceRoleForceNew (77.87s)

@anGie44 anGie44 merged commit 4940461 into master Aug 28, 2020
@anGie44 anGie44 deleted the td-opsworks-tests branch August 28, 2020 16:54
@anGie44 anGie44 added this to the v3.5.0 milestone Aug 28, 2020
anGie44 added a commit that referenced this pull request Aug 28, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/opsworks Issues and PRs that pertain to the opsworks service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants