d/lb - add private_ipv4_address attribute to subnet mapping

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11404, Closes #14565.

Release note for CHANGELOG:

data_source_aws_lb - add `private_ipv4_address` attribute to subnet mapping

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAWSLB_'
--- PASS: TestAccDataSourceAWSLB_basic (289.27s)
--- PASS: TestAccDataSourceAWSLB_BackwardsCompatibility(301.30s)

[bflad]

Sigh, #8223 rears its head again. 😖 Thanks for working on this, @DrFaust92, is this still WIP (according to the PR title)?

[DrFaust92]

@bflad, yeah debugging an issue where subnet_mapping differs from data source and resource. Looking into it.

[DrFaust92]

@bflad, there was another issue with the Set func missing hiding there as well.

[ewbankkit]

Closes #14565.

[kartik-moolya]

Can we expedite this please. I'm having to move all of my code to cloudformation due to this bug :(

[bflad]

Thank you for working on this, @DrFaust92 I think we should be able to remove the Set function below. Other than that, we can get this in today. 👍

[bflad]

This import was very recently moved as part of our Terraform Plugin SDK v1 removal: #14593

It now lives at:

"github.com/terraform-providers/terraform-provider-aws/aws/internal/hashcode"

That being said, adding Set functions to data sources should generally not be necessary and especially after this fix in SDK version 2: hashicorp/terraform-plugin-sdk#197

If this is rebased against the current commit on the main branch, which is all up to date with SDK v2, the Set function can hopefully be removed.

[bflad]

Thank you for fixing these. 😄

[DrFaust92]

Thanks @bflad, fixed and added some more tests to cover all attributes

[bflad]

Looks great, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAWSLB_basic (219.10s)
--- PASS: TestAccDataSourceAWSLB_BackwardsCompatibility (219.37s)

[ghost]

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!