Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding codebuild.EnvironmentTypeWindowsServer2019Container as a valid… #14532

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

CianGrimnir
Copy link
Contributor

… option for Codebuild environment type #14335

Changes proposed in this pull request:

  • Adds codebuild.EnvironmentTypeWindowsServer2019Container as a valid type for the aws_codebuild_project environment type.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #14335

I currently don't have AWS account to perform acceptance tests. It will be great if someone helps me out with it.

@CianGrimnir CianGrimnir requested a review from a team August 10, 2020 04:38
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 10, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 10, 2020
@bflad bflad added this to the v3.2.0 milestone Aug 10, 2020
@bflad bflad self-assigned this Aug 13, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @RakeshCodeBase 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCodeBuildProject_ARMContainer (68.47s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (115.42s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (121.42s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (126.96s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (145.88s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (117.80s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (121.72s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (139.64s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (122.19s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (122.73s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (88.72s)
--- PASS: TestAccAWSCodeBuildProject_basic (75.35s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (133.25s)
--- PASS: TestAccAWSCodeBuildProject_Cache (315.05s)
--- PASS: TestAccAWSCodeBuildProject_Description (129.16s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (73.90s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (42.31s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (194.71s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (171.81s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value (192.12s)
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (66.25s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (173.53s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (171.64s)
--- PASS: TestAccAWSCodeBuildProject_QueuedTimeout (147.44s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (78.78s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (122.33s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (121.59s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (121.60s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (106.60s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (121.30s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (103.55s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (99.52s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (69.90s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (57.95s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit (117.72s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub (122.47s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise (125.21s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (146.50s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit (162.15s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub (144.89s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise (145.20s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (129.87s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (123.92s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (126.08s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (122.46s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (88.34s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (72.70s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (73.28s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (77.10s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (73.07s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (41.73s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (75.77s)
--- PASS: TestAccAWSCodeBuildProject_SourceVersion (34.46s)
--- PASS: TestAccAWSCodeBuildProject_Tags (114.83s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (162.53s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (71.50s)
--- PASS: TestAccAWSCodeBuildProject_WindowsServer2019Container (73.48s)
--- PASS: TestAWSCodeBuildProject_nameValidation (0.00s)
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)

@bflad bflad merged commit 1901f9a into hashicorp:master Aug 13, 2020
bflad added a commit that referenced this pull request Aug 13, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_codebuild_project is missing a valid enivornment type (WINDOWS_SERVER_2019_CONTAINER)
2 participants