-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/codeartifact_repository - new resource #14429
r/codeartifact_repository - new resource #14429
Conversation
@DrFaust92 Thanks for this! Is there any progress on the PR? 👍 :-) |
424ab33
to
35fd198
Compare
66a9695
to
a80d5a7
Compare
doc changes Co-authored-by: Kit Ewbank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactRepository_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactRepository_ -timeout 120m
=== RUN TestAccAWSCodeArtifactRepository_basic
=== PAUSE TestAccAWSCodeArtifactRepository_basic
=== RUN TestAccAWSCodeArtifactRepository_owner
=== PAUSE TestAccAWSCodeArtifactRepository_owner
=== RUN TestAccAWSCodeArtifactRepository_description
=== PAUSE TestAccAWSCodeArtifactRepository_description
=== RUN TestAccAWSCodeArtifactRepository_upstreams
=== PAUSE TestAccAWSCodeArtifactRepository_upstreams
=== RUN TestAccAWSCodeArtifactRepository_disappears
=== PAUSE TestAccAWSCodeArtifactRepository_disappears
=== CONT TestAccAWSCodeArtifactRepository_owner
=== CONT TestAccAWSCodeArtifactRepository_upstreams
=== CONT TestAccAWSCodeArtifactRepository_disappears
=== CONT TestAccAWSCodeArtifactRepository_basic
=== CONT TestAccAWSCodeArtifactRepository_description
=== CONT TestAccAWSCodeArtifactRepository_disappears
resource_aws_codeartifact_repository_test.go:214: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactRepository_disappears (31.82s)
--- PASS: TestAccAWSCodeArtifactRepository_owner (35.02s)
--- PASS: TestAccAWSCodeArtifactRepository_basic (35.28s)
--- PASS: TestAccAWSCodeArtifactRepository_description (51.38s)
--- PASS: TestAccAWSCodeArtifactRepository_upstreams (71.76s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 71.805s
…der-aws into f-aws_codeartifact_repository
…form-provider-aws into f-aws_codeartifact_repository
resolved provider conflict |
LGTM! 🚀 Thanks @DrFaust92 Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactRepository_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactRepository_ -timeout 120m
=== RUN TestAccAWSCodeArtifactRepository_basic
=== PAUSE TestAccAWSCodeArtifactRepository_basic
=== RUN TestAccAWSCodeArtifactRepository_owner
=== PAUSE TestAccAWSCodeArtifactRepository_owner
=== RUN TestAccAWSCodeArtifactRepository_description
=== PAUSE TestAccAWSCodeArtifactRepository_description
=== RUN TestAccAWSCodeArtifactRepository_upstreams
=== PAUSE TestAccAWSCodeArtifactRepository_upstreams
=== RUN TestAccAWSCodeArtifactRepository_disappears
=== PAUSE TestAccAWSCodeArtifactRepository_disappears
=== CONT TestAccAWSCodeArtifactRepository_basic
=== CONT TestAccAWSCodeArtifactRepository_upstreams
=== CONT TestAccAWSCodeArtifactRepository_description
=== CONT TestAccAWSCodeArtifactRepository_owner
=== CONT TestAccAWSCodeArtifactRepository_disappears
resource_aws_codeartifact_repository_test.go:214: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactRepository_disappears (16.94s)
--- PASS: TestAccAWSCodeArtifactRepository_basic (18.52s)
--- PASS: TestAccAWSCodeArtifactRepository_owner (19.41s)
--- PASS: TestAccAWSCodeArtifactRepository_description (31.34s)
--- PASS: TestAccAWSCodeArtifactRepository_upstreams (46.57s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 48.605s |
This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #13714
Release note for CHANGELOG:
Output from acceptance testing: