Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_iam_server_certificate: Remove state hashing from certificate_body, certificate_chain, and private_key arguments #14187

Merged
merged 1 commit into from
Jul 29, 2020
Merged

resource/aws_iam_server_certificate: Remove state hashing from certificate_body, certificate_chain, and private_key arguments #14187

merged 1 commit into from
Jul 29, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13406

Release note for CHANGELOG:

* resource/aws_iam_server_certificate: Remove state hashing from `certificate_body`, `certificate_chain`, and `private_key` arguments for new or recreated resources

Output from acceptance testing:

--- PASS: TestAccAWSIAMServerCertificate_name_prefix (6.05s)
--- PASS: TestAccAWSIAMServerCertificate_disappears (6.10s)
--- PASS: TestAccAWSIAMServerCertificate_Path (6.48s)
--- PASS: TestAccAWSIAMServerCertificate_basic (6.54s)
--- PASS: TestAccAWSIAMServerCertificate_file (10.07s)

@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Jul 15, 2020
@bflad bflad added this to the v3.0.0 milestone Jul 15, 2020
@bflad bflad requested a review from a team July 15, 2020 17:18
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. labels Jul 15, 2020
@bflad bflad mentioned this pull request Jul 23, 2020
Closed
@anGie44 anGie44 self-requested a review July 28, 2020 14:56
anGie44
anGie44 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 -- just needs to resolve the conflict w/the upgrade guide

Output of acceptance tests:

--- PASS: TestAccAWSIAMServerCertificate_disappears (5.93s)
--- PASS: TestAccAWSIAMServerCertificate_name_prefix (6.80s)
--- PASS: TestAccAWSIAMServerCertificate_basic (7.71s)
--- PASS: TestAccAWSIAMServerCertificate_Path (7.62s)
--- PASS: TestAccAWSIAMServerCertificate_file (11.69s)

@bflad
resource/aws_iam_server_certificate: Remove state hashing from certif…
e2cea22 
…icate_body, certificate_chain, and private_key arguments

Reference: #13406

Output from acceptance testing:

```
--- PASS: TestAccAWSIAMServerCertificate_name_prefix (6.05s)
--- PASS: TestAccAWSIAMServerCertificate_disappears (6.10s)
--- PASS: TestAccAWSIAMServerCertificate_Path (6.48s)
--- PASS: TestAccAWSIAMServerCertificate_basic (6.54s)
--- PASS: TestAccAWSIAMServerCertificate_file (10.07s)
```
@bflad bflad force-pushed the td-aws_iam_server_certificate-hash-removal branch from ad459ec to e2cea22 Compare July 29, 2020 12:10
@bflad
Copy link
Contributor Author

bflad commented Jul 29, 2020

Rebased for documentation merge conflict and will merge when CI is ✅

@bflad bflad merged commit a59cbd7 into master Jul 29, 2020
@bflad bflad deleted the td-aws_iam_server_certificate-hash-removal branch July 29, 2020 12:55
bflad added a commit that referenced this pull request Jul 29, 2020
@bflad
Update CHANGELOG for #14187
4e9c81d
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Remove Hashing from State Storage
2 participants
@bflad @anGie44