-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/codebuild_report_group - add new resource #12573
Conversation
Verified acceptance tests: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildReportGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildReportGroup_ -timeout 120m
=== RUN TestAccAWSCodeBuildReportGroup_basic
=== PAUSE TestAccAWSCodeBuildReportGroup_basic
=== RUN TestAccAWSCodeBuildReportGroup_updated
=== PAUSE TestAccAWSCodeBuildReportGroup_updated
=== RUN TestAccAWSCodeBuildReportGroup_disappears
=== PAUSE TestAccAWSCodeBuildReportGroup_disappears
=== CONT TestAccAWSCodeBuildReportGroup_basic
=== CONT TestAccAWSCodeBuildReportGroup_disappears
=== CONT TestAccAWSCodeBuildReportGroup_updated
--- PASS: TestAccAWSCodeBuildReportGroup_disappears (61.10s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (65.39s)
--- PASS: TestAccAWSCodeBuildReportGroup_updated (92.03s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 92.073s |
@DrFaust92 awesome, thx for implementing this! |
0317df3
to
44996f1
Compare
change disappears test
refactor tests add comment about encryption
44996f1
to
e627619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeBuildReportGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildReportGroup_ -timeout 120m
=== RUN TestAccAWSCodeBuildReportGroup_basic
=== PAUSE TestAccAWSCodeBuildReportGroup_basic
=== RUN TestAccAWSCodeBuildReportGroup_export_s3
=== PAUSE TestAccAWSCodeBuildReportGroup_export_s3
=== RUN TestAccAWSCodeBuildReportGroup_tags
=== PAUSE TestAccAWSCodeBuildReportGroup_tags
=== RUN TestAccAWSCodeBuildReportGroup_disappears
=== PAUSE TestAccAWSCodeBuildReportGroup_disappears
=== CONT TestAccAWSCodeBuildReportGroup_basic
=== CONT TestAccAWSCodeBuildReportGroup_disappears
=== CONT TestAccAWSCodeBuildReportGroup_tags
=== CONT TestAccAWSCodeBuildReportGroup_export_s3
=== CONT TestAccAWSCodeBuildReportGroup_disappears
resource_aws_codebuild_report_group_test.go:142: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeBuildReportGroup_disappears (17.93s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (24.08s)
--- PASS: TestAccAWSCodeBuildReportGroup_tags (47.91s)
--- PASS: TestAccAWSCodeBuildReportGroup_export_s3 (59.30s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 59.341s
rebased
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
Output from acceptance testing:
--- PASS: TestAccAWSCodeBuildReportGroup_disappears (12.89s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (17.09s)
--- PASS: TestAccAWSCodeBuildReportGroup_export_s3 (30.81s)
--- PASS: TestAccAWSCodeBuildReportGroup_tags (38.91s)
This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #12178
Release note for CHANGELOG:
Output from acceptance testing: