Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restriction on length of name_prefix for aws_iam_server_certificate #1217

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Fix restriction on length of name_prefix for aws_iam_server_certificate #1217

merged 1 commit into from
Jul 24, 2017

Conversation

joshuaspence
Copy link
Contributor

Currently name_prefix is restricted to 30 characters, which is unnecessarily prohibitive.

…icate`

Currently `name_prefix` is restricted to 30 characters, which is unnecessarily prohibitive.
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original limit was apparently just arbitrary value: https://github.com/hashicorp/terraform/pull/5178/files#r53246807
resource.PrefixedUniqueId produces 26 digit value and 102+26=128 so this makes sense.
👍 Thanks

@radeksimko radeksimko merged commit 81cdac0 into hashicorp:master Jul 24, 2017
@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jul 24, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants