Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tagging for Gamelift resources - Alias, Build & Session Queue #11486

Merged
merged 12 commits into from
Jan 10, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 6, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11384

Release note for CHANGELOG:

resource_aws_gamelift_alias - add `tags` argument
resource_aws_gamelift_build - add `tags` argument and `arn` attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGameliftAlias_'
--- PASS: TestAccAWSGameliftAlias_basic (88.10s)
--- PASS: TestAccAWSGameliftAlias_tags (110.00s) 
--- PASS: TestAccAWSGameliftAlias_disappears (42.51s)
--- PASS: TestAccAWSGameliftAlias_fleetRouting (1464.86s)
...
$ make testacc TESTARGS='-run=TestAccAWSGameliftBuild_'
--- PASS: TestAccAWSGameliftBuild_basic (69.16s)
--- PASS: TestAccAWSGameliftBuild_tags (94.39s)
--- PASS: TestAccAWSGameliftBuild_disappears (30.10s)
$ make testacc TESTARGS='-run=TestAccAWSGameliftGameSessionQueue_'
--- PASS: TestAccAWSGameliftGameSessionQueue_basic (72.84s)
--- PASS: TestAccAWSGameliftGameSessionQueue_tags (96.20s)
--- PASS: TestAccAWSGameliftGameSessionQueue_disappears (30.12s)

@DrFaust92 DrFaust92 requested a review from a team January 6, 2020 11:40
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/gamelift Issues and PRs that pertain to the gamelift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 6, 2020
@bflad
Copy link
Contributor

bflad commented Jan 6, 2020

@DrFaust92 can we please split off the keyvaluetags package changes into their own PR so they can be merged quickly and resource implementations done in parallel? Thanks! 👍

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 6, 2020
@DrFaust92 DrFaust92 changed the title [WIP] support tagging for Gamelift resources Support tagging for Gamelift resources - Alias, Build & Session Queue Jan 6, 2020
@DrFaust92
Copy link
Collaborator Author

DrFaust92 commented Jan 6, 2020

@bflad, I'm done with most of them (leaving the fleet resource aside as it takes a while to run its tests)

ill split this if you see fit.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 10, 2020
@bflad bflad self-assigned this Jan 10, 2020
@bflad bflad added this to the v2.45.0 milestone Jan 10, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSGameliftAlias_basic (70.67s)
--- PASS: TestAccAWSGameliftAlias_disappears (7.73s)
--- PASS: TestAccAWSGameliftAlias_fleetRouting (1598.09s)
--- PASS: TestAccAWSGameliftAlias_tags (44.43s)

--- PASS: TestAccAWSGameliftBuild_basic (23.79s)
--- PASS: TestAccAWSGameliftBuild_disappears (13.38s)
--- PASS: TestAccAWSGameliftBuild_tags (53.62s)

--- PASS: TestAccAWSGameliftGameSessionQueue_basic (25.65s)
--- PASS: TestAccAWSGameliftGameSessionQueue_disappears (7.38s)
--- PASS: TestAccAWSGameliftGameSessionQueue_tags (39.32s)

@bflad bflad merged commit a41ed8d into hashicorp:master Jan 10, 2020
bflad added a commit that referenced this pull request Jan 10, 2020
@ghost
Copy link

ghost commented Jan 17, 2020

This has been released in version 2.45.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the gamelift-tags branch March 15, 2020 07:49
@ghost
Copy link

ghost commented Mar 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/gamelift Issues and PRs that pertain to the gamelift service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants