Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/aws_elb: Export arn attribute #11345

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

115100
Copy link
Contributor

@115100 115100 commented Dec 18, 2019

The documentation says that data source for aws_elb shall return the
same attributes as the resource type.

This commit exports arn on the data source to match the documented
behaviour.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

data-source/aws_elb: Export arn attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAWSELB_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccDataSourceAWSELB_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccDataSourceAWSELB_basic
=== PAUSE TestAccDataSourceAWSELB_basic
=== CONT  TestAccDataSourceAWSELB_basic
--- PASS: TestAccDataSourceAWSELB_basic (52.27s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       52.307s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.002s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.008s [no tests to run]

The documentation says that data source for aws_elb shall return the
same attributes as the resource type.

This commit exports arn on the data source to match the documented
behaviour.
@115100 115100 requested a review from a team December 18, 2019 14:28
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/elb Issues and PRs that pertain to the elb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 18, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @115100 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAWSELB_basic (13.85s)

@bflad bflad added this to the v2.43.0 milestone Dec 18, 2019
@bflad bflad merged commit 7c63a76 into hashicorp:master Dec 18, 2019
bflad added a commit that referenced this pull request Dec 18, 2019
@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants