resource/aws_batch_compute_environment: Propose resource recreation when updating compute_resources configuration block tags argument #10937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing compute_resources configuration block tags argument Reference: #2696 Reference: https://docs.aws.amazon.com/batch/latest/APIReference/API_UpdateComputeEnvironment.html The upstream API does not support updating compute resource tags, therefore we update Terraform to propose resource recreation when they are modified instead of perpetually showing a difference. Output from acceptance testing: ``` --- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (20.68s) --- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (23.28s) --- PASS: TestAccAWSBatchComputeEnvironment_createUnmanaged (44.92s) --- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (45.81s) --- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (55.24s) --- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (57.90s) --- PASS: TestAccAWSBatchComputeEnvironment_createSpot (58.45s) --- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithTags (60.50s) --- PASS: TestAccAWSBatchComputeEnvironment_updateMaxvCpus (76.98s) --- PASS: TestAccAWSBatchComputeEnvironment_updateState (77.05s) --- PASS: TestAccAWSBatchComputeEnvironment_updateInstanceType (84.66s) --- PASS: TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName (91.90s) ```
bflad
added
bug
ghost
added
needs-triage
bflad
deleted the
b-aws_batch_compute_environment-compute_resources-tags-ForceNew
branch
bflad
added a commit
that referenced
this pull request
Nov 21, 2019
|
This has been released in version 2.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
pixelpogo
pushed a commit
to babbel/terraform-provider-aws
that referenced
this pull request
Nov 22, 2019
…ing compute_resources configuration block tags argument (hashicorp#10937) Reference: hashicorp#2696 Reference: https://docs.aws.amazon.com/batch/latest/APIReference/API_UpdateComputeEnvironment.html The upstream API does not support updating compute resource tags, therefore we update Terraform to propose resource recreation when they are modified instead of perpetually showing a difference. Output from acceptance testing: ``` --- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (20.68s) --- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (23.28s) --- PASS: TestAccAWSBatchComputeEnvironment_createUnmanaged (44.92s) --- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (45.81s) --- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (55.24s) --- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (57.90s) --- PASS: TestAccAWSBatchComputeEnvironment_createSpot (58.45s) --- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithTags (60.50s) --- PASS: TestAccAWSBatchComputeEnvironment_updateMaxvCpus (76.98s) --- PASS: TestAccAWSBatchComputeEnvironment_updateState (77.05s) --- PASS: TestAccAWSBatchComputeEnvironment_updateInstanceType (84.66s) --- PASS: TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName (91.90s) ```
pixelpogo
pushed a commit
to babbel/terraform-provider-aws
that referenced
this pull request
Nov 22, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
breathingdust
removed
the
needs-triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #2696
Reference: https://docs.aws.amazon.com/batch/latest/APIReference/API_UpdateComputeEnvironment.html
Release note for CHANGELOG:
The upstream API does not support updating compute resource tags, therefore we update Terraform to propose resource recreation when they are modified instead of perpetually showing a difference.
Output from acceptance testing: