r/aws_wafregional_rate_based_rule - add tagging support + expose arn + read after create

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9289

Release note for CHANGELOG:

- resource/resource_aws_wafregional_rate_based_rule: Add `tags` argument and `arn` attribute.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalRateBasedRule_'
=== RUN   TestAccAWSWafRegionalRateBasedRule_basic
=== PAUSE TestAccAWSWafRegionalRateBasedRule_basic
=== CONT  TestAccAWSWafRegionalRateBasedRule_basic
--- PASS: TestAccAWSWafRegionalRateBasedRule_basic (175.73s)
=== RUN   TestAccAWSWafRegionalRateBasedRule_tags
=== PAUSE TestAccAWSWafRegionalRateBasedRule_tags
=== RUN   TestAccAWSWafRegionalRateBasedRule_changeNameForceNew
=== PAUSE TestAccAWSWafRegionalRateBasedRule_changeNameForceNew
=== CONT  TestAccAWSWafRegionalRateBasedRule_changeNameForceNew
=== RUN   TestAccAWSWafRegionalRateBasedRule_disappears
=== PAUSE TestAccAWSWafRegionalRateBasedRule_disappears
=== CONT  TestAccAWSWafRegionalRateBasedRule_disappears
=== RUN   TestAccAWSWafRegionalRateBasedRule_changePredicates
=== PAUSE TestAccAWSWafRegionalRateBasedRule_changePredicates
=== CONT  TestAccAWSWafRegionalRateBasedRule_changePredicates
=== RUN   TestAccAWSWafRegionalRateBasedRule_changeRateLimit
=== PAUSE TestAccAWSWafRegionalRateBasedRule_changeRateLimit
=== CONT  TestAccAWSWafRegionalRateBasedRule_changeRateLimit
=== RUN   TestAccAWSWafRegionalRateBasedRule_noPredicates
=== PAUSE TestAccAWSWafRegionalRateBasedRule_noPredicates
=== CONT  TestAccAWSWafRegionalRateBasedRule_noPredicates
--- PASS: TestAccAWSWafRegionalRateBasedRule_noPredicates (126.86s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changePredicates (226.29s)
=== CONT  TestAccAWSWafRegionalRateBasedRule_tags
--- PASS: TestAccAWSWafRegionalRateBasedRule_disappears (106.22s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changeNameForceNew (293.62s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changeRateLimit (122.15s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_tags (159.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	418.062s

...

[bflad]

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSWafRegionalRateBasedRule_noPredicates (16.12s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changeRateLimit (18.16s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_tags (59.44s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changeNameForceNew (63.98s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_basic (65.44s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changePredicates (73.59s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_disappears (74.58s)

[ghost]

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!