r/aws_wafregional_rule - add tagging support + expose arn + read after create

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9289

Release note for CHANGELOG:

- resource/resource_aws_wafregional_rule: Add `tags` argument and `arn` attribute.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalRule_'
=== RUN   TestAccAWSWafRegionalRule_basic
=== PAUSE TestAccAWSWafRegionalRule_basic
=== CONT  TestAccAWSWafRegionalRule_basic
--- PASS: TestAccAWSWafRegionalRule_basic (103.13s)
=== RUN   TestAccAWSWafRegionalRule_tags
=== PAUSE TestAccAWSWafRegionalRule_tags
=== CONT  TestAccAWSWafRegionalRule_tags
--- PASS: TestAccAWSWafRegionalRule_tags (146.42s)
=== RUN   TestAccAWSWafRegionalRule_changeNameForceNew
=== PAUSE TestAccAWSWafRegionalRule_changeNameForceNew
=== CONT  TestAccAWSWafRegionalRule_changeNameForceNew
--- PASS: TestAccAWSWafRegionalRule_changeNameForceNew (171.76s)
=== RUN   TestAccAWSWafRegionalRule_disappears
=== PAUSE TestAccAWSWafRegionalRule_disappears
=== CONT  TestAccAWSWafRegionalRule_disappears
--- PASS: TestAccAWSWafRegionalRule_disappears (84.05s)
=== RUN   TestAccAWSWafRegionalRule_noPredicates
=== PAUSE TestAccAWSWafRegionalRule_noPredicates
=== CONT  TestAccAWSWafRegionalRule_noPredicates
--- PASS: TestAccAWSWafRegionalRule_noPredicates (57.08s)
=== RUN   TestAccAWSWafRegionalRule_changePredicates
=== PAUSE TestAccAWSWafRegionalRule_changePredicates
=== CONT  TestAccAWSWafRegionalRule_changePredicates
--- PASS: TestAccAWSWafRegionalRule_changePredicates (156.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	273.389s

...

[bflad]

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSWafRegionalRule_disappears (36.53s)
--- PASS: TestAccAWSWafRegionalRule_noPredicates (39.85s)
--- PASS: TestAccAWSWafRegionalRule_tags (46.46s)
--- PASS: TestAccAWSWafRegionalRule_changePredicates (72.39s)
--- PASS: TestAccAWSWafRegionalRule_changeNameForceNew (74.27s)
--- PASS: TestAccAWSWafRegionalRule_basic (92.20s)

[ghost]

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!