Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tag Support to Storage Gateway Gateway Resource #10588

Merged
merged 7 commits into from
Nov 2, 2019
Merged

Add Tag Support to Storage Gateway Gateway Resource #10588

merged 7 commits into from
Nov 2, 2019

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 21, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7826

Release note for CHANGELOG:

- resource/resource_aws_storagegateway_gateway: Add `tags` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewayGateway_tags'

=== RUN   TestAccAWSStorageGatewayGateway_tags
=== PAUSE TestAccAWSStorageGatewayGateway_tags
=== CONT  TestAccAWSStorageGatewayGateway_tags
--- PASS: TestAccAWSStorageGatewayGateway_tags (424.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	431.726s

...

@DrFaust92 DrFaust92 requested a review from a team October 21, 2019 21:59
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 21, 2019
@DrFaust92 DrFaust92 changed the title [WIP] Add Tag Support to Storage Gateway Gateway Resource Add Tag Support to Storage Gateway Gateway Resource Oct 21, 2019
@DrFaust92
Copy link
Collaborator Author

I did not run all tests because i seem to get inconsistent errors, if anyone can check this

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 2, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 2, 2019
bflad
bflad approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (188.56s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (188.70s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (191.77s)
--- PASS: TestAccAWSStorageGatewayGateway_tags (206.41s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (260.26s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (260.47s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (268.70s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (271.56s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (712.86s)

@bflad bflad merged commit 9944b75 into hashicorp:master Nov 2, 2019
bflad added a commit that referenced this pull request Nov 2, 2019
@bflad
Update CHANGELOG for #10588
2db829d
@DrFaust92 DrFaust92 deleted the storage-gateway-tag-support branch November 2, 2019 06:38
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @bflad