Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending status for aws_redshift_cluster resource #10530

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10337

Release note for CHANGELOG:

r/aws_redshift_cluster: add support `available, prep-for-resize` status for pending case

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRedshiftCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSRedshiftCluster_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSRedshiftCluster_basic
=== PAUSE TestAccAWSRedshiftCluster_basic
=== CONT  TestAccAWSRedshiftCluster_basic
--- PASS: TestAccAWSRedshiftCluster_basic (350.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	350.134s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.048s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.034s [no tests to run]

@teraken0509 teraken0509 requested a review from a team October 17, 2019 06:18
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/redshift Issues and PRs that pertain to the redshift service. labels Oct 17, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Jan 17, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 🚀

Output from acceptance testing (failure unrelated):

--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (572.52s)
--- FAIL: TestAccAWSRedshiftCluster_iamRoles (586.43s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (594.56s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (629.68s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (632.66s)
--- PASS: TestAccAWSRedshiftCluster_tags (692.89s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (705.95s)
--- PASS: TestAccAWSRedshiftCluster_basic (849.81s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (867.52s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (928.53s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1090.77s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2139.92s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (2182.02s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (2182.31s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (2660.86s)

@bflad bflad added this to the v2.46.0 milestone Jan 18, 2020
@bflad bflad merged commit 8204a29 into hashicorp:master Jan 18, 2020
bflad added a commit that referenced this pull request Jan 18, 2020
@ghost
Copy link

ghost commented Jan 23, 2020

This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/redshift Issues and PRs that pertain to the redshift service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redshift elastic resize fails due to unexpected state
2 participants