Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ca_cert_identifier to rds instance #10490

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

sunilkumarmohanty
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #10489

Release note for CHANGELOG:

resource/db_instance: Add ca_cert_identifier 

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDBInstance_CACertificateIdentifier'

@sunilkumarmohanty sunilkumarmohanty requested a review from a team October 13, 2019 09:04
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 13, 2019
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/M Managed by automation to categorize the size of a PR. labels Oct 13, 2019
@martinssipenko
Copy link
Contributor

martinssipenko commented Oct 14, 2019

Closes #10100
Closes #10417

@VishalBaghla
Copy link

@james-gonzalez @svanzoest When this PR will be merged?

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 15, 2019
@bflad bflad added this to the v2.37.0 milestone Nov 15, 2019
@scott2449
Copy link

Looks like we'll be getting this fix next week! Thanks @bflad 👏

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much @sunilkumarmohanty 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (423.91s)
--- PASS: TestAccAWSDBInstance_basic (549.13s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (598.47s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (577.19s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (777.31s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (574.76s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (503.84s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (902.93s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (600.69s)
--- PASS: TestAccAWSDBInstance_generatedName (446.29s)
--- PASS: TestAccAWSDBInstance_iamAuth (578.34s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (579.52s)
--- PASS: TestAccAWSDBInstance_kmsKey (526.24s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (624.11s)
--- PASS: TestAccAWSDBInstance_MinorVersion (512.70s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (828.15s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (746.31s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (983.72s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (690.25s)
--- PASS: TestAccAWSDBInstance_MSSQL_Domain (3253.88s)
--- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (2916.40s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1643.74s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (2049.99s)
--- PASS: TestAccAWSDBInstance_namePrefix (558.48s)
--- PASS: TestAccAWSDBInstance_Password (470.55s)
--- PASS: TestAccAWSDBInstance_portUpdate (608.53s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1547.36s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1793.30s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1510.97s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1674.21s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (2087.90s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1556.72s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1365.83s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1725.52s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1675.26s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1835.18s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (2271.24s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1595.06s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1656.30s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1907.55s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1489.86s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1256.07s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1584.12s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2038.69s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1385.25s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1191.17s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1613.64s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1497.08s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1289.89s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1326.26s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1442.00s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1517.80s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1441.37s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1331.96s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1393.54s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1876.69s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (4350.14s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1290.77s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1462.83s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1312.05s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1129.26s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1191.82s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1293.28s)
--- PASS: TestAccAWSDBInstance_subnetGroup (955.28s)

@@ -1,14 +1,14 @@
---
layout: "aws"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that we are going to revert the content of this documentation file to the current content (plus the addition of the new attribute) to prevent breaking open pull requests.

@bflad bflad merged commit 201a0b2 into hashicorp:master Nov 15, 2019
bflad added a commit that referenced this pull request Nov 15, 2019
@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@sirocode
Copy link

It does not work while creating a RDS instance from the RDS snapshot. I tried with 2.38.0.

Should I open another issue?

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_db_instance should support ca_cert_identifier
8 participants