Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing eu-north-1 Amazon Redshift audit logging account ID #10134

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Add missing eu-north-1 Amazon Redshift audit logging account ID #10134

merged 1 commit into from
Sep 24, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10129.

Release note for CHANGELOG:

data-source/aws_cloudtrail_service_account: Support `cn-north-1` region
data-source/aws_elastic_beanstalk_hosted_zone: Support `ap-east-1`, `ap-northeast-3`, `us-gov-east-1` and `us-gov-west-1` regions
data-source/aws_elb_hosted_zone_id: Support `cn-northwest-1` region. Correct value for `cn-north-1` region
data-source/aws_redshift_service_account: Support `ap-northeast-3`, `cn-north-1`, `eu-north-1` and `me-south-1` regions

Output from acceptance testing:

n/a

@ewbankkit ewbankkit requested a review from a team September 17, 2019 16:00
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elb Issues and PRs that pertain to the elb service. service/redshift Issues and PRs that pertain to the redshift service. labels Sep 17, 2019
ewbankkit
ewbankkit commented Sep 18, 2019
View reviewed changes
aws/data_source_aws_elb_hosted_zone_id.go
@@ -26,7 +28,6 @@ var elbHostedZoneIdPerRegionMap = map[string]string{
"sa-east-1": "Z2P70J7HTTTPLU",
"us-east-1": "Z35SXDOTRQ7X7K",
"us-east-2": "Z3AADJGX6KTTL2",
"us-gov-west-1": "048591011584",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a Route 53 hosted zone ID, it's the AWS account ID for access log delivery.
See aws/data_source_aws_elb_service_account.go.

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 24, 2019
@bflad bflad added this to the v2.30.0 milestone Sep 24, 2019
bflad
bflad approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ewbankkit 🚀

@bflad bflad merged commit 8c9ca47 into hashicorp:master Sep 24, 2019
bflad added a commit that referenced this pull request Sep 24, 2019
@bflad
Update CHANGELOG for #10134
00441c7
@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit deleted the issue-10129 branch October 1, 2019 19:35
@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elb Issues and PRs that pertain to the elb service. service/redshift Issues and PRs that pertain to the redshift service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.30.0
Development

Successfully merging this pull request may close these issues.

New region eu-north-1 and Amazon Redshift
3 participants
@ewbankkit @bflad @jukie