Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip_address attribute to aws_lightsail_static_ip_attachment resource #10109

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

RulerOf
Copy link
Contributor

@RulerOf RulerOf commented Sep 14, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

No issues opened for this feature—please let me know if one is necessary.

Release note for CHANGELOG:

Adds support for the documented ip_address attribute to aws_lightsail_static_ip_attachment resource.

Output from acceptance testing: Not included

I don't have the skill set to write terraform provider acceptance tests. I can only really report that this patch functions as described.

@RulerOf RulerOf requested a review from a team September 14, 2019 01:44
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/lightsail Issues and PRs that pertain to the lightsail service. labels Sep 14, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 24, 2019
@bflad bflad added this to the v2.30.0 milestone Sep 24, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, @RulerOf 🚀 For reference, the testing for this case is adding the below into the _basic test (handled during merge):

resource.TestCheckResourceAttrSet("aws_lightsail_static_ip_attachment.test", "ip_address"),

Output from acceptance testing:

--- PASS: TestAccAWSLightsailStaticIpAttachment_disappears (81.16s)
--- PASS: TestAccAWSLightsailStaticIpAttachment_basic (84.47s)

@bflad bflad merged commit 10efd9a into hashicorp:master Sep 24, 2019
bflad added a commit that referenced this pull request Sep 24, 2019
@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lightsail Issues and PRs that pertain to the lightsail service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants