Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Log Analytics in log bucket destination #179

Conversation

daniel-cit
Copy link
Contributor

Fixes #178

@daniel-cit daniel-cit requested review from imrannayer and a team as code owners October 31, 2023 01:21
@imrannayer
Copy link
Collaborator

/gcbrun

@daniel-cit daniel-cit requested a review from imrannayer November 3, 2023 12:51
@imrannayer
Copy link
Collaborator

imrannayer commented Nov 3, 2023

@daniel-cit can u plz add this feature in examples

@daniel-cit
Copy link
Contributor Author

daniel-cit commented Nov 3, 2023

@daniel-cit can u plz add this feature in examples

Should it be a new example or an updated in one of the existing examples, like the project one?

  • I will add a new example log-analytics based in the project example + tests

@imrannayer
Copy link
Collaborator

lets try existing example.

@daniel-cit daniel-cit requested a review from imrannayer November 3, 2023 23:58
@imrannayer
Copy link
Collaborator

/gcbrun

1 similar comment
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit 511585e into terraform-google-modules:master Nov 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Log Analytics in logbucket module
2 participants