Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:logbucket sink in same project #118

Merged
merged 22 commits into from
Aug 9, 2022
Merged

fix:logbucket sink in same project #118

merged 22 commits into from
Aug 9, 2022

Conversation

felipecrescencio-cit
Copy link
Contributor

Fix for #116 issue.
PR changes:

  • New variable grant_write_permission_on_bkt on logbucket destination module that enables the user to not grant logbucket write permission, that is the use case when sink and logbucket are in the same project - reference
  • Example of usage logbucket in projects
  • Integrated test of logbucket with projects

felipecrescencio-cit and others added 21 commits July 20, 2022 19:07
@felipecrescencio-cit
Fix Copyright year
2347d0a
@felipecrescencio-cit
New variable to deal with sink and logbucket in same project
cd18efc
@felipecrescencio-cit
When sink and logbucket in same project no new service account is cre…
40bf306 
…ated
@felipecrescencio-cit
New examples for logbucket at project-level
a047e25
@felipecrescencio-cit
Changed name of new variable to a meaningful name
79dc77b
@felipecrescencio-cit
Created example of logbucket with project usage
118e72c
@felipecrescencio-cit
Changed name of bucket due to colisions during integrated tests
ebc3e4b
@felipecrescencio-cit
Setup a new project for logbucket project testing in same and other p…
cf81d2f 
…rojects
@felipecrescencio-cit
Integrated tests to Logbucket Project example
151ee3e
@felipecrescencio-cit
Revert mischanged copyright year
e735121
@felipecrescencio-cit
Shorten variable names
ccf60ea
@felipecrescencio-cit @daniel-cit
Fix logbucket/project example README.md
9f0126f 
Co-authored-by: Daniel Andrade <[email protected]>
@felipecrescencio-cit @daniel-cit
Fix logbucket/project example README.md
4675247 
Co-authored-by: Daniel Andrade <[email protected]>
@felipecrescencio-cit
Revert mischanged copyright year
46e6e41
@felipecrescencio-cit
Inline constants
84e7940
@felipecrescencio-cit
Changed variables creation place to right before usage
6114dc2
@felipecrescencio-cit
Remove retention_days to keep it default user better understanding ex…
1b10674 
…ample
@felipecrescencio-cit
-Created constant defaultRetentionDays and kept both examples with th…
8693453 
…is default for user better understanding code and example

-Changed assert bucket name to remove substring and compare to a built string fully qualified name
-Combined similar asserts to tabular
@felipecrescencio-cit @daniel-cit
Removed because empty is string default value
3fcace8 
Co-authored-by: Daniel Andrade <[email protected]>
@felipecrescencio-cit @daniel-cit
Removed sink prefix because there is only one writerIdentity
997681a 
Co-authored-by: Daniel Andrade <[email protected]>
@felipecrescencio-cit
Fix assert writerIdentity message for examples
ae53703
@felipecrescencio-cit felipecrescencio-cit mentioned this pull request Aug 4, 2022
Closed
bharathkkb
bharathkkb approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @felipecrescencio-cit

@comment-bot-dev
Copy link

@felipecrescencio-cit
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 44758c2 into terraform-google-modules:master Aug 9, 2022
@release-please release-please bot mentioned this pull request Aug 9, 2022
Merged
@felipecrescencio-cit felipecrescencio-cit deleted the fix-logbucket-sink-same-project branch August 9, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees

@felipecrescencio-cit felipecrescencio-cit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felipecrescencio-cit @comment-bot-dev @bharathkkb